From 34bfd3a8f37985b395625c81a7d106ee1f455453 Mon Sep 17 00:00:00 2001 From: Anders Bjerner Date: Mon, 28 Feb 2022 23:06:59 +0100 Subject: [PATCH] Fixes issue with OrderByDescending generating invalid SQL (#11673) * Fixes issue with OrderByDescending generating invalid SQL * Update OrderByDexcending with single field for consistecy Co-authored-by: Michael --- src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs b/src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs index 05f15f7372..ed51d4a182 100644 --- a/src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs +++ b/src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs @@ -252,7 +252,7 @@ namespace Umbraco.Extensions /// The Sql statement. public static Sql OrderByDescending(this Sql sql, Expression> field) { - return sql.OrderBy("(" + sql.SqlContext.SqlSyntax.GetFieldName(field) + ") DESC"); + return sql.OrderByDescending(sql.SqlContext.SqlSyntax.GetFieldName(field)); } /// @@ -268,7 +268,7 @@ namespace Umbraco.Extensions var columns = fields.Length == 0 ? sql.GetColumns(withAlias: false) : fields.Select(x => sqlSyntax.GetFieldName(x)).ToArray(); - return sql.OrderBy(columns.Select(x => x + " DESC")); + return sql.OrderByDescending(columns); } ///