From ef79e6c0e987525e1dde23230788be9baeaca1f8 Mon Sep 17 00:00:00 2001
From: Jeavon <jeavon@crumpled-dog.com>
Date: Wed, 3 Apr 2019 10:54:53 +0100
Subject: [PATCH 1/2] fix: make XmlHelper class public

---
 src/Umbraco.Core/Xml/XmlHelper.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Umbraco.Core/Xml/XmlHelper.cs b/src/Umbraco.Core/Xml/XmlHelper.cs
index a852f97002..41025d21ef 100644
--- a/src/Umbraco.Core/Xml/XmlHelper.cs
+++ b/src/Umbraco.Core/Xml/XmlHelper.cs
@@ -14,7 +14,7 @@ namespace Umbraco.Core.Xml
     /// <summary>
     /// The XmlHelper class contains general helper methods for working with xml in umbraco.
     /// </summary>
-    internal class XmlHelper
+    public class XmlHelper
     {
         /// <summary>
         /// Creates or sets an attribute on the XmlNode if an Attributes collection is available

From e23b9153a046d862d52f8410670c195840400c91 Mon Sep 17 00:00:00 2001
From: Jeavon <jeavon@crumpled-dog.com>
Date: Thu, 4 Apr 2019 09:45:04 +0100
Subject: [PATCH 2/2] fix: set some methods within XmlHelper to internal

---
 src/Umbraco.Core/Xml/XmlHelper.cs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/Umbraco.Core/Xml/XmlHelper.cs b/src/Umbraco.Core/Xml/XmlHelper.cs
index 41025d21ef..3fd8dcaea5 100644
--- a/src/Umbraco.Core/Xml/XmlHelper.cs
+++ b/src/Umbraco.Core/Xml/XmlHelper.cs
@@ -341,7 +341,7 @@ namespace Umbraco.Core.Xml
         /// </summary>
         /// <param name="n">The XmlNode.</param>
         /// <returns>the value as a string</returns>
-        public static string GetNodeValue(XmlNode n)
+        internal static string GetNodeValue(XmlNode n)
         {
             var value = string.Empty;
             if (n == null || n.FirstChild == null)
@@ -373,7 +373,7 @@ namespace Umbraco.Core.Xml
         /// <param name="rootName">Name of the root.</param>
         /// <param name="elementName">Name of the element.</param>
         /// <returns>Returns an <c>System.Xml.XmlDocument</c> representation of the delimited string data.</returns>
-        public static XmlDocument Split(string data, string[] separator, string rootName, string elementName)
+        internal static XmlDocument Split(string data, string[] separator, string rootName, string elementName)
         {
             return Split(new XmlDocument(), data, separator, rootName, elementName);
         }
@@ -387,7 +387,7 @@ namespace Umbraco.Core.Xml
         /// <param name="rootName">Name of the root node.</param>
         /// <param name="elementName">Name of the element node.</param>
         /// <returns>Returns an <c>System.Xml.XmlDocument</c> representation of the delimited string data.</returns>
-        public static XmlDocument Split(XmlDocument xml, string data, string[] separator, string rootName, string elementName)
+        internal static XmlDocument Split(XmlDocument xml, string data, string[] separator, string rootName, string elementName)
         {
             // load new XML document.
             xml.LoadXml(string.Concat("<", rootName, "/>"));
@@ -416,7 +416,7 @@ namespace Umbraco.Core.Xml
         /// </summary>
         /// <param name="tag"></param>
         /// <returns></returns>
-        public static Dictionary<string, string> GetAttributesFromElement(string tag)
+        internal static Dictionary<string, string> GetAttributesFromElement(string tag)
         {
             var m =
                 Regex.Matches(tag, "(?<attributeName>\\S*)=\"(?<attributeValue>[^\"]*)\"",