diff --git a/src/Umbraco.Compat7/Umbraco.Compat7.csproj b/src/Umbraco.Compat7/Umbraco.Compat7.csproj index bae12013d6..a014cc8abb 100644 --- a/src/Umbraco.Compat7/Umbraco.Compat7.csproj +++ b/src/Umbraco.Compat7/Umbraco.Compat7.csproj @@ -48,6 +48,7 @@ Umbraco.Core + {651e1350-91b6-44b7-bd60-7207006d7003} Umbraco.Web diff --git a/src/Umbraco.Core/Services/Implement/UserService.cs b/src/Umbraco.Core/Services/Implement/UserService.cs index 2dfe93c381..598f742e60 100644 --- a/src/Umbraco.Core/Services/Implement/UserService.cs +++ b/src/Umbraco.Core/Services/Implement/UserService.cs @@ -668,6 +668,7 @@ namespace Umbraco.Core.Services.Implement { //This is called a TON. Go get the full user from cache which should already be IProfile var fullUser = GetUserById(id); + if (fullUser == null) return null; var asProfile = fullUser as IProfile; return asProfile ?? new UserProfile(fullUser.Id, fullUser.Name); } diff --git a/src/Umbraco.Examine/Umbraco.Examine.csproj b/src/Umbraco.Examine/Umbraco.Examine.csproj index 4bf61c3689..de401af610 100644 --- a/src/Umbraco.Examine/Umbraco.Examine.csproj +++ b/src/Umbraco.Examine/Umbraco.Examine.csproj @@ -52,11 +52,6 @@ - - - Umbraco.Core - - @@ -64,6 +59,10 @@ + + {31785bc3-256c-4613-b2f5-a1b0bdded8c1} + Umbraco.Core + \ No newline at end of file diff --git a/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj b/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj index d28f0432dd..67b67a0a5c 100644 --- a/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj +++ b/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj @@ -425,26 +425,26 @@ ..\packages\System.Xml.XmlDocument.4.3.0\lib\net46\System.Xml.XmlDocument.dll True - ..\packages\System.Xml.XPath.4.3.0\lib\net46\System.Xml.XPath.dll True - - ../packages/System.Xml.XPath.XDocument.4.0.1/lib/net46/System.Xml.XPath.XDocument.dll + ../packages/System.Xml.XPath.XDocument.4.3.0/lib/net46/System.Xml.XPath.XDocument.dll True + + {31785bc3-256c-4613-b2f5-a1b0bdded8c1} + Umbraco.Core + Umbraco.Examine {07FBC26B-2927-4A22-8D96-D644C667FECC} - - Umbraco.Core - + {651e1350-91b6-44b7-bd60-7207006d7003} Umbraco.Web @@ -1080,10 +1080,10 @@ xcopy "$(ProjectDir)"..\packages\SqlServerCE.4.0.0.1\x86\*.* "$(TargetDir)x86\" $(OriginalFileName.Replace("$(ProjectDir)", "$(WebProjectOutputDir)")) - diff --git a/src/Umbraco.Web/Editors/UsersController.cs b/src/Umbraco.Web/Editors/UsersController.cs index 1b4a515bce..0ab42b9d7f 100644 --- a/src/Umbraco.Web/Editors/UsersController.cs +++ b/src/Umbraco.Web/Editors/UsersController.cs @@ -203,11 +203,10 @@ namespace Umbraco.Web.Editors var filterQuery = Current.SqlContext.Query(); - //if the current user is not the administrator, then don't include this in the results. - if (Security.CurrentUser.IsSuper() == false) + if (!Security.CurrentUser.IsSuper()) { // only super can see super - filterQuery.Where(x => x.Id != Constants.Security.SuperId); + filterQuery.Where(x => !x.IsSuper()); } if (filter.IsNullOrWhiteSpace() == false) diff --git a/src/Umbraco.Web/HealthCheck/NotificationMethods/NotificationMethodBase.cs b/src/Umbraco.Web/HealthCheck/NotificationMethods/NotificationMethodBase.cs index af471e63ac..f35df0062e 100644 --- a/src/Umbraco.Web/HealthCheck/NotificationMethods/NotificationMethodBase.cs +++ b/src/Umbraco.Web/HealthCheck/NotificationMethods/NotificationMethodBase.cs @@ -1,7 +1,7 @@ using System.Collections.Generic; +using System.Reflection; using System.Threading; using System.Threading.Tasks; -using NuGet; using Umbraco.Core.Configuration; using Umbraco.Core.Configuration.HealthChecks; diff --git a/src/Umbraco.Web/IUmbracoComponentRendererWithField.cs b/src/Umbraco.Web/IUmbracoComponentRendererWithField.cs deleted file mode 100644 index 30754e28a3..0000000000 --- a/src/Umbraco.Web/IUmbracoComponentRendererWithField.cs +++ /dev/null @@ -1,39 +0,0 @@ -using System.Web; -using Umbraco.Core.Models.PublishedContent; - -namespace Umbraco.Web -{ - /// - /// Methods used to render umbraco components as HTML in templates - /// - public interface IUmbracoComponentRendererWithField : IUmbracoComponentRenderer - { - /// - /// Renders an field to the template - /// - /// - /// - /// - /// - /// - /// - /// - /// - /// - /// - /// - /// - /// - /// - //// - /// - IHtmlString Field(IPublishedContent currentPage, string fieldAlias, - string altFieldAlias = "", string altText = "", string insertBefore = "", string insertAfter = "", - bool recursive = false, bool convertLineBreaks = false, bool removeParagraphTags = false, - RenderFieldCaseType casing = RenderFieldCaseType.Unchanged, - RenderFieldEncodingType encoding = RenderFieldEncodingType.Unchanged, - bool formatAsDate = false, - bool formatAsDateWithTime = false, - string formatAsDateWithTimeSeparator = ""); - } -} diff --git a/src/Umbraco.Web/Umbraco.Web.csproj b/src/Umbraco.Web/Umbraco.Web.csproj index b4bc19fca9..6e12f51097 100644 --- a/src/Umbraco.Web/Umbraco.Web.csproj +++ b/src/Umbraco.Web/Umbraco.Web.csproj @@ -103,13 +103,14 @@ + + {31785bc3-256c-4613-b2f5-a1b0bdded8c1} + Umbraco.Core + Umbraco.Examine {07FBC26B-2927-4A22-8D96-D644C667FECC} - - Umbraco.Core - @@ -163,7 +164,6 @@ - diff --git a/src/Umbraco.Web/UmbracoComponentRenderer.cs b/src/Umbraco.Web/UmbracoComponentRenderer.cs index 5cbb0a230e..b23f38fcde 100644 --- a/src/Umbraco.Web/UmbracoComponentRenderer.cs +++ b/src/Umbraco.Web/UmbracoComponentRenderer.cs @@ -24,7 +24,7 @@ namespace Umbraco.Web /// /// Used by UmbracoHelper /// - internal class UmbracoComponentRenderer : IUmbracoComponentRendererWithField + internal class UmbracoComponentRenderer : IUmbracoComponentRenderer { private readonly UmbracoContext _umbracoContext; diff --git a/src/umbraco.sln b/src/umbraco.sln index 9f4f6ba1f4..f810bd75ef 100644 --- a/src/umbraco.sln +++ b/src/umbraco.sln @@ -86,6 +86,10 @@ EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Umbraco.Tests.Benchmarks", "Umbraco.Tests.Benchmarks\Umbraco.Tests.Benchmarks.csproj", "{86DEB346-089F-4106-89C8-D852B9CF2A33}" EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Umbraco.Compat7", "Umbraco.Compat7\Umbraco.Compat7.csproj", "{185E098F-5706-4B97-B404-EB974F05F633}" + ProjectSection(ProjectDependencies) = postProject + {651E1350-91B6-44B7-BD60-7207006D7003} = {651E1350-91B6-44B7-BD60-7207006D7003} + {31785BC3-256C-4613-B2F5-A1B0BDDED8C1} = {31785BC3-256C-4613-B2F5-A1B0BDDED8C1} + EndProjectSection EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution