(c)));
@@ -190,7 +189,6 @@ namespace Umbraco.Tests.TestHelpers
return new ServiceContext(
publicAccessService,
- taskService,
domainService,
auditService,
localizedTextService,
diff --git a/src/Umbraco.Tests/UI/LegacyDialogTests.cs b/src/Umbraco.Tests/UI/LegacyDialogTests.cs
index ffbca1e0e8..ba7c4f0e66 100644
--- a/src/Umbraco.Tests/UI/LegacyDialogTests.cs
+++ b/src/Umbraco.Tests/UI/LegacyDialogTests.cs
@@ -25,8 +25,8 @@ namespace Umbraco.Tests.UI
[TestCase(typeof(MemberGroupTasks), Constants.Applications.Members)]
[TestCase(typeof(dictionaryTasks), Constants.Applications.Settings)]
- [TestCase(typeof(macroTasks), Constants.Applications.Developer)]
- [TestCase(typeof(CreatedPackageTasks), Constants.Applications.Developer)]
+ [TestCase(typeof(macroTasks), Constants.Applications.Packages)]
+ [TestCase(typeof(CreatedPackageTasks), Constants.Applications.Packages)]
public void Check_Assigned_Apps_For_Tasks(Type taskType, string app)
{
var task = (LegacyDialogTask)Activator.CreateInstance(taskType);
diff --git a/src/Umbraco.Tests/Umbraco.Tests.csproj b/src/Umbraco.Tests/Umbraco.Tests.csproj
index a0822efc15..0d346f74dd 100644
--- a/src/Umbraco.Tests/Umbraco.Tests.csproj
+++ b/src/Umbraco.Tests/Umbraco.Tests.csproj
@@ -227,8 +227,6 @@
Added in Umbraco version 8.0
+This directive is a wrapper of the flatpickr library. Use it to render a date time picker.
+For extra details about options and events take a look here: https://flatpickr.js.org/
+
+Use this directive to render a date time picker
+
+Markup example
+
+
+
+
+
+
+
+
+
+Controller example
+
+ (function () {
+ "use strict";
+
+ function Controller() {
+
+ var vm = this;
+
+ vm.date = "2018-10-10 10:00";
+
+ vm.config = {
+ enableTime: true,
+ dateFormat: "Y-m-d H:i",
+ time_24hr: true
+ };
+
+ vm.datePickerChange = datePickerChange;
+
+ function datePickerChange(selectedDates, dateStr, instance) {
+ // handle change
+ }
+
+ }
+
+ angular.module("umbraco").controller("My.Controller", Controller);
+
+ })();
+
+
+@param {object} ngModel (binding): Config object for the date picker.
+@param {object} options (binding): Config object for the date picker.
+@param {callback} onSetup (callback): onSetup gets triggered when the date picker is initialized
+@param {callback} onChange (callback): onChange gets triggered when the user selects a date, or changes the time on a selected date.
+@param {callback} onOpen (callback): onOpen gets triggered when the calendar is opened.
+@param {callback} onClose (callback): onClose gets triggered when the calendar is closed.
+@param {callback} onMonthChange (callback): onMonthChange gets triggered when the month is changed, either by the user or programmatically.
+@param {callback} onYearChange (callback): onMonthChange gets triggered when the year is changed, either by the user or programmatically.
+@param {callback} onReady (callback): onReady gets triggered once the calendar is in a ready state.
+@param {callback} onValueUpdate (callback): onValueUpdate gets triggered when the input value is updated with a new date string.
+@param {callback} onDayCreate (callback): Take full control of every date cell with theonDayCreate()hook.
+**/
+
+(function() {
+ 'use strict';
+
+ var umbFlatpickr = {
+ template: '' +
+ '
' +
+ ' ',
+ controller: umbFlatpickrCtrl,
+ transclude: true,
+ bindings: {
+ ngModel: '<',
+ options: '<',
+ onSetup: '&?',
+ onChange: '&?',
+ onOpen: '&?',
+ onClose: '&?',
+ onMonthChange: '&?',
+ onYearChange: '&?',
+ onReady: '&?',
+ onValueUpdate: '&?',
+ onDayCreate: '&?'
+ }
+ };
+
+ function umbFlatpickrCtrl($element, $timeout, $scope, assetsService) {
+ var ctrl = this;
+ var loaded = false;
+
+ ctrl.$onInit = function() {
+
+ // load css file for the date picker
+ assetsService.loadCss('lib/flatpickr/flatpickr.css', $scope);
+
+ // load the js file for the date picker
+ assetsService.loadJs('lib/flatpickr/flatpickr.js', $scope).then(function () {
+ // init date picker
+ loaded = true;
+ grabElementAndRunFlatpickr();
+ });
+
+ };
+
+ function grabElementAndRunFlatpickr() {
+ $timeout(function() {
+ var transcludeEl = $element.find('ng-transclude')[0];
+ var element = transcludeEl.children[0];
+
+ setDatepicker(element);
+ }, 0, true);
+ }
+
+ function setDatepicker(element) {
+ var fpLib = flatpickr ? flatpickr : FlatpickrInstance;
+
+ if (!fpLib) {
+ return console.warn('Unable to find any flatpickr installation');
+ }
+
+ setUpCallbacks();
+
+ var fpInstance = new fpLib(element, ctrl.options);
+
+ if (ctrl.onSetup) {
+ ctrl.onSetup({
+ fpItem: fpInstance
+ });
+ }
+
+ // If has ngModel set the date
+ if (ctrl.ngModel) {
+ fpInstance.setDate(ctrl.ngModel);
+ }
+
+ // destroy the flatpickr instance when the dom element is removed
+ angular.element(element).on('$destroy', function() {
+ fpInstance.destroy();
+ });
+
+ // Refresh the scope
+ $scope.$applyAsync();
+ }
+
+ function setUpCallbacks() {
+ // bind hook for onChange
+ if(ctrl.options && ctrl.onChange) {
+ ctrl.options.onChange = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onChange({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ // bind hook for onOpen
+ if(ctrl.options && ctrl.onOpen) {
+ ctrl.options.onOpen = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onOpen({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ // bind hook for onOpen
+ if(ctrl.options && ctrl.onClose) {
+ ctrl.options.onClose = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onClose({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ // bind hook for onMonthChange
+ if(ctrl.options && ctrl.onMonthChange) {
+ ctrl.options.onMonthChange = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onMonthChange({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ // bind hook for onYearChange
+ if(ctrl.options && ctrl.onYearChange) {
+ ctrl.options.onYearChange = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onYearChange({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ // bind hook for onReady
+ if(ctrl.options && ctrl.onReady) {
+ ctrl.options.onReady = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onReady({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ // bind hook for onValueUpdate
+ if(ctrl.onValueUpdate) {
+ ctrl.options.onValueUpdate = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onValueUpdate({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ // bind hook for onDayCreate
+ if(ctrl.onDayCreate) {
+ ctrl.options.onDayCreate = function(selectedDates, dateStr, instance) {
+ $timeout(function() {
+ ctrl.onDayCreate({selectedDates: selectedDates, dateStr: dateStr, instance: instance});
+ });
+ };
+ }
+
+ }
+ }
+
+ angular.module('umbraco.directives').component('umbFlatpickr', umbFlatpickr);
+
+})();
\ No newline at end of file
diff --git a/src/Umbraco.Web.UI.Client/src/common/mocks/services/localization.mocks.js b/src/Umbraco.Web.UI.Client/src/common/mocks/services/localization.mocks.js
index 409ec24d51..28aae834b3 100644
--- a/src/Umbraco.Web.UI.Client/src/common/mocks/services/localization.mocks.js
+++ b/src/Umbraco.Web.UI.Client/src/common/mocks/services/localization.mocks.js
@@ -644,24 +644,14 @@ angular.module('umbraco.mocks').
"templateEditor_usedIfAllEmpty": "Will only be used when the field values above are empty",
"templateEditor_usedIfEmpty": "This field will only be used if the primary field is empty",
"templateEditor_withTime": "Yes, with time. Seperator: ",
- "translation_assignedTasks": "Tasks assigned to you",
- "translation_assignedTasksHelp": " The list below shows translation tasks assigned to you . To see a detailed view including comments, click on 'Details' or just the page name. You can also download the page as XML directly by clicking the 'Download Xml' link. created by you . To see a detailed view including comments, click on 'Details' or just the page name. You can also download the page as XML directly by clicking the 'Download Xml' link. To close a translation task, please go to the Details view and click the 'Close' button. ",
- "translation_pageHasBeenSendToTranslation": "The page '%0%' has been send to translation",
+ "translation_pageHasBeenSendToTranslation": "The page '%0%' has been send to translation",
"translation_sendToTranslate": "Send the page '%0%' to translation",
- "translation_taskAssignedBy": "Assigned by",
- "translation_taskOpened": "Task opened",
"translation_totalWords": "Total words",
"translation_translateTo": "Translate to",
"translation_translationDone": "Translation completed.",
diff --git a/src/Umbraco.Web.UI.Client/src/common/services/contenteditinghelper.service.js b/src/Umbraco.Web.UI.Client/src/common/services/contenteditinghelper.service.js
index ba2df1a68a..777b336447 100644
--- a/src/Umbraco.Web.UI.Client/src/common/services/contenteditinghelper.service.js
+++ b/src/Umbraco.Web.UI.Client/src/common/services/contenteditinghelper.service.js
@@ -146,7 +146,7 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, notifica
if (!args.methods) {
throw "args.methods is not defined";
}
- if (!args.methods.saveAndPublish || !args.methods.sendToPublish || !args.methods.unpublish) {
+ if (!args.methods.saveAndPublish || !args.methods.sendToPublish || !args.methods.unpublish || !args.methods.schedulePublish) {
throw "args.methods does not contain all required defined methods";
}
@@ -190,6 +190,16 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, notifica
alias: "unpublish",
addEllipsis: args.content.variants && args.content.variants.length > 1 ? "true" : "false"
};
+ case "SCHEDULE":
+ //schedule publish - schedule doesn't have a permission letter so
+ // the button letter is made unique so it doesn't collide with anything else
+ return {
+ letter: ch,
+ labelKey: "buttons_schedulePublish",
+ handler: args.methods.schedulePublish,
+ alias: "schedulePublish",
+ addEllipsis: "true"
+ };
default:
return null;
}
@@ -200,7 +210,7 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, notifica
//This is the ideal button order but depends on circumstance, we'll use this array to create the button list
// Publish, SendToPublish
- var buttonOrder = ["U", "H"];
+ var buttonOrder = ["U", "H", "SCHEDULE"];
//Create the first button (primary button)
//We cannot have the Save or SaveAndPublish buttons if they don't have create permissions when we are creating a new item.
@@ -215,6 +225,7 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, notifica
break;
}
}
+
//Here's the special check, if the button still isn't set and we are creating and they have create access
//we need to add the Save button
if (!buttons.defaultButton && args.create && _.contains(args.content.allowedActions, "C")) {
@@ -237,6 +248,12 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, notifica
}
}
+ // if publishing is allowed also allow schedule publish
+ // we add this manually becuase it doesn't have a permission so it wont
+ // get picked up by the loop through permissions
+ if( _.contains(args.content.allowedActions, "U")) {
+ buttons.subButtons.push(createButtonDefinition("SCHEDULE"));
+ }
// if we are not creating, then we should add unpublish too,
// so long as it's already published and if the user has access to publish
@@ -249,40 +266,6 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, notifica
}
}
- // If we have a scheduled publish or unpublish date change the default button to
- // "save" and update the label to "save and schedule
- if (args.content.releaseDate || args.content.removeDate) {
-
- // if save button is alread the default don't change it just update the label
- if (buttons.defaultButton && buttons.defaultButton.letter === "A") {
- buttons.defaultButton.labelKey = "buttons_saveAndSchedule";
- return buttons;
- }
-
- if (buttons.defaultButton && buttons.subButtons && buttons.subButtons.length > 0) {
- // save a copy of the default so we can push it to the sub buttons later
- var defaultButtonCopy = angular.copy(buttons.defaultButton);
- var newSubButtons = [];
-
- // if save button is not the default button - find it and make it the default
- angular.forEach(buttons.subButtons, function (subButton) {
-
- if (subButton.letter === "A") {
- buttons.defaultButton = subButton;
- buttons.defaultButton.labelKey = "buttons_saveAndSchedule";
- } else {
- newSubButtons.push(subButton);
- }
-
- });
-
- // push old default button into subbuttons
- newSubButtons.push(defaultButtonCopy);
- buttons.subButtons = newSubButtons;
- }
-
- }
-
return buttons;
},
diff --git a/src/Umbraco.Web.UI.Client/src/less/belle.less b/src/Umbraco.Web.UI.Client/src/less/belle.less
index cc98ec306b..ac8279e3ab 100644
--- a/src/Umbraco.Web.UI.Client/src/less/belle.less
+++ b/src/Umbraco.Web.UI.Client/src/less/belle.less
@@ -96,6 +96,7 @@
@import "components/tree/umb-actions.less";
@import "components/tree/umb-tree-item.less";
+
@import "components/editor.less";
@import "components/overlays.less";
@import "components/card.less";
@@ -104,6 +105,7 @@
@import "components/umb-editor-navigation.less";
@import "components/umb-editor-sub-views.less";
@import "components/editor/subheader/umb-editor-sub-header.less";
+@import "components/umb-flatpickr.less";
@import "components/umb-grid-selector.less";
@import "components/umb-child-selector.less";
@import "components/umb-group-builder.less";
diff --git a/src/Umbraco.Web.UI.Client/src/less/components/overlays.less b/src/Umbraco.Web.UI.Client/src/less/components/overlays.less
index 3fbe32134b..6538a751f9 100644
--- a/src/Umbraco.Web.UI.Client/src/less/components/overlays.less
+++ b/src/Umbraco.Web.UI.Client/src/less/components/overlays.less
@@ -75,7 +75,7 @@
/* ---------- OVERLAY CENTER ---------- */
.umb-overlay.umb-overlay-center {
position: absolute;
- width: 500px;
+ width: 600px;
height: auto;
top: 50%;
left: 50%;
diff --git a/src/Umbraco.Web.UI.Client/src/less/components/umb-flatpickr.less b/src/Umbraco.Web.UI.Client/src/less/components/umb-flatpickr.less
new file mode 100644
index 0000000000..1848d55d96
--- /dev/null
+++ b/src/Umbraco.Web.UI.Client/src/less/components/umb-flatpickr.less
@@ -0,0 +1,21 @@
+.flatpickr-calendar.flatpickr-calendar {
+ border-radius: @baseBorderRadius;
+ box-shadow: 0 5px 10px 0 rgba(0,0,0,0.16);
+}
+
+span.flatpickr-day {
+ border-radius: @baseBorderRadius;
+ border: none;
+}
+
+span.flatpickr-day:hover {
+ background-color: @gray-10;
+}
+
+span.flatpickr-day.selected {
+ background-color: @turquoise;
+}
+
+span.flatpickr-day.selected:hover {
+ background-color: @turquoise-d1;
+}
\ No newline at end of file
diff --git a/src/Umbraco.Web.UI.Client/src/less/main.less b/src/Umbraco.Web.UI.Client/src/less/main.less
index 6d567c5fb3..0284a79865 100644
--- a/src/Umbraco.Web.UI.Client/src/less/main.less
+++ b/src/Umbraco.Web.UI.Client/src/less/main.less
@@ -48,6 +48,7 @@ h5.-black {
border: none
}
.bootstrap-datetimepicker-widget {
+ width: auto !important;
td {
&.active, span.active {
background: @turquoise !important;
diff --git a/src/Umbraco.Web.UI.Client/src/less/properties.less b/src/Umbraco.Web.UI.Client/src/less/properties.less
index 06f05ab0aa..916f1b5a3a 100644
--- a/src/Umbraco.Web.UI.Client/src/less/properties.less
+++ b/src/Umbraco.Web.UI.Client/src/less/properties.less
@@ -1,61 +1,19 @@
//----- SCHEDULED PUBLISH ------
-.place-holder {
- height: 60px;
- width: 60px;
- margin: 15px auto;
- background-color: @gray-8;
-}
-
.date-wrapper {
display: flex;
- justify-content: space-around;
flex-direction: row;
+ border-top: 1px solid @gray-10;
+ border-bottom: 1px solid @gray-10;
}
-.date-container {
- text-align: center;
+.date-wrapper__date {
+ padding: 10px;
+ flex: 1 1 50%;
}
-.date-wrapper__number{
- font-size: 40px;
- line-height: 50px;
- color: @gray-2;
- font-weight: 900;
-}
-
-.date-container__title {
- font-size: 16px;
- font-weight: bold;
- color: @gray-3;
- margin-bottom: 5px;
-}
-
-.date-container__date {
- padding: 0 10px;
-}
-.date-container__date:hover {
- background-color: @gray-10;
- cursor: pointer;
-}
-
-.date-wrapper__date{
- font-size: 13px;
- color: @gray-6;
- margin: 0;
-}
-
-.data-wrapper__add{
- font-size: 18px;
- line-height: 10px;
- color: @gray-8;
- font-weight: 900;
- margin: 0;
-}
-
-.date-separate {
- width: 1px;
- background-color: @gray-8;
+.date-wrapper__date:last-of-type {
+ border-left: 1px solid @gray-10;
}
//------------------- HISTORY ------------------
diff --git a/src/Umbraco.Web.UI.Client/src/preview/preview.controller.js b/src/Umbraco.Web.UI.Client/src/preview/preview.controller.js
index e87f3a59bf..beb6353bde 100644
--- a/src/Umbraco.Web.UI.Client/src/preview/preview.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/preview/preview.controller.js
@@ -22,6 +22,20 @@ var app = angular.module("umbraco.preview", ['umbraco.resources', 'umbraco.servi
// signalr hub
var previewHub = $.connection.previewHub;
+ // visibility tracking
+ var dirtyContent = false;
+ var visibleContent = true;
+
+ document.addEventListener('visibilitychange', function () {
+ visibleContent = !document.hidden;
+ if (visibleContent && dirtyContent) {
+ dirtyContent = false;
+ console.log("Visible, reloading.")
+ var iframeDoc = (iframe.contentWindow || iframe.contentDocument);
+ iframeDoc.location.reload();
+ }
+ });
+
previewHub.client.refreshed = function (message, sender) {
console.log("Notified by SignalR preview hub (" + message + ").");
@@ -30,6 +44,13 @@ var app = angular.module("umbraco.preview", ['umbraco.resources', 'umbraco.servi
return;
}
+ if (!visibleContent) {
+ console.log("Not visible, will reload.");
+ dirtyContent = true;
+ return;
+ }
+
+ console.log("Reloading.");
var iframeDoc = (iframe.contentWindow || iframe.contentDocument);
iframeDoc.location.reload();
};
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/content/umb-content-node-info.html b/src/Umbraco.Web.UI.Client/src/views/components/content/umb-content-node-info.html
index c2e5df6f30..03d4318ba2 100644
--- a/src/Umbraco.Web.UI.Client/src/views/components/content/umb-content-node-info.html
+++ b/src/Umbraco.Web.UI.Client/src/views/components/content/umb-content-node-info.html
@@ -112,78 +112,7 @@