Merge pull request #891 from umbraco/temp-U4-7128

Fixes: U4-7128 Send to Translation gives YSOD

src/Umbraco.Core/Persistence/Mappers/TaskTypeMapper.cs

@@ -0,0 +1,38 @@
+using System.Collections.Concurrent;
+using Umbraco.Core.Models;
+using Umbraco.Core.Models.Rdbms;
+
+namespace Umbraco.Core.Persistence.Mappers
+{
+    /// <summary>
+    /// Represents a <see cref="TaskType"/> to DTO mapper used to translate the properties of the public api 
+    /// implementation to that of the database's DTO as sql: [tableName].[columnName].
+    /// </summary>
+    [MapperFor(typeof(TaskType))]
+    public sealed class TaskTypeMapper : BaseMapper
+    {
+        private static readonly ConcurrentDictionary<string, DtoMapModel> PropertyInfoCacheInstance = new ConcurrentDictionary<string, DtoMapModel>();
+
+        //NOTE: its an internal class but the ctor must be public since we're using Activator.CreateInstance to create it
+        // otherwise that would fail because there is no public constructor.
+        public TaskTypeMapper()
+        {
+            BuildMap();
+        }
+
+        #region Overrides of BaseMapper
+
+        internal override ConcurrentDictionary<string, DtoMapModel> PropertyInfoCache
+        {
+            get { return PropertyInfoCacheInstance; }
+        }
+
+        internal override void BuildMap()
+        {
+            CacheMap<TaskType, TaskTypeDto>(src => src.Id, dto => dto.Id);
+            CacheMap<TaskType, TaskTypeDto>(src => src.Alias, dto => dto.Alias);
+        }
+
+        #endregion
+    }
+}

src/Umbraco.Core/Umbraco.Core.csproj

@@ -404,6 +404,7 @@
     <Compile Include="Persistence\Mappers\AccessMapper.cs" />
     <Compile Include="Persistence\Mappers\DomainMapper.cs" />
     <Compile Include="Persistence\Mappers\MigrationEntryMapper.cs" />
+    <Compile Include="Persistence\Mappers\TaskTypeMapper.cs" />
     <Compile Include="Persistence\Migrations\Upgrades\TargetVersionSevenThreeTwo\EnsureMigrationsTableIdentityIsCorrect.cs" />
     <Compile Include="Persistence\Migrations\Upgrades\TargetVersionSevenThreeZero\AddExternalLoginsTable.cs" />
     <Compile Include="Persistence\Migrations\Upgrades\TargetVersionSevenThreeZero\AddForeignKeysForLanguageAndDictionaryTables.cs" />

src/umbraco.cms/businesslogic/translation/Translation.cs

@@ -19,13 +19,15 @@ namespace umbraco.cms.businesslogic.translation
         public static void MakeNew(CMSNode Node, User User, User Translator, Language Language, string Comment,
                                    bool IncludeSubpages, bool SendEmail)
         {
+            // Get translation taskType for obsolete task constructor
+            var taskType = ApplicationContext.Current.Services.TaskService.GetTaskTypeByAlias("toTranslate");
+
             // Create pending task
-            Task t = new Task();
+            Task t = new Task(new Umbraco.Core.Models.Task(taskType));
             t.Comment = Comment;
             t.Node = Node;
             t.ParentUser = User;
             t.User = Translator;
-            t.Type = new TaskType("toTranslate");
             t.Save();
 
             // Add log entry