From 38ac99e46fa5fe67ea424398481c8dfa8136f161 Mon Sep 17 00:00:00 2001 From: Shannon Date: Thu, 4 Mar 2021 15:19:52 +1100 Subject: [PATCH] adds notes --- src/Umbraco.Examine.Lucene/UmbracoExamineIndex.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Examine.Lucene/UmbracoExamineIndex.cs b/src/Umbraco.Examine.Lucene/UmbracoExamineIndex.cs index 096db978da..6440c7bd6a 100644 --- a/src/Umbraco.Examine.Lucene/UmbracoExamineIndex.cs +++ b/src/Umbraco.Examine.Lucene/UmbracoExamineIndex.cs @@ -31,12 +31,12 @@ namespace Umbraco.Cms.Infrastructure.Examine private readonly ILoggerFactory _loggerFactory; private readonly IRuntimeState _runtimeState; + // note // wrapping all operations that end up calling base.SafelyProcessQueueItems in a safe call // context because they will fork a thread/task/whatever which should *not* capture our - // call context (and the database it can contain)! ideally we should be able to override - // SafelyProcessQueueItems but that's not possible in the current version of Examine. - // TODO: Make SafelyProcessQueueItems overrideable or make this easier + // call context (and the database it can contain)! + // TODO: FIX Examine to not flow the ExecutionContext so callers don't need to worry about this! /// /// Create a new