From 3bf43d7ce3ac016482f92c4a4a6d4a399920dbb6 Mon Sep 17 00:00:00 2001
From: Shannon <sdeminick@gmail.com>
Date: Mon, 17 Jun 2019 16:48:35 +1000
Subject: [PATCH] adds a unit test showing that the SimilarNodeName is broken.

---
 .../Repositories/SimilarNodeNameTests.cs       | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs b/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs
index 961496ae16..ca47e5928c 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs
@@ -36,6 +36,8 @@ namespace Umbraco.Tests.Persistence.Repositories
                 Assert.IsTrue(result > 0, "Expected >0 but was " + result);
         }
 
+        
+
         [Test]
         public void OrderByTest()
         {
@@ -96,5 +98,21 @@ namespace Umbraco.Tests.Persistence.Repositories
 
             Assert.AreEqual(expected, SimilarNodeName.GetUniqueName(names, nodeId, nodeName));
         }
+
+        [Test]
+        public void TestMany()
+        {
+            var names = new[]
+            {
+                new SimilarNodeName { Id = 1, Name = "Alpha (2)" },
+                new SimilarNodeName { Id = 2, Name = "Test" },
+                new SimilarNodeName { Id = 3, Name = "Test (1)" },
+                new SimilarNodeName { Id = 4, Name = "Test (2)" },
+                new SimilarNodeName { Id = 22, Name = "Test (1) (1)" },
+            };
+
+            //fixme - this will yield "Test (2)" which is already in use
+            Assert.AreEqual("Test (3)", SimilarNodeName.GetUniqueName(names, 0, "Test"));
+        }
     }
 }