From 3ca09e734111debcf9839ce21e63bcf92bfc6a61 Mon Sep 17 00:00:00 2001 From: Lee Kelleher Date: Thu, 5 Jun 2025 15:17:38 +0100 Subject: [PATCH] V16 Variant breadcrumbs: the parent entity-type and unique were being mixed up (#19491) Variant breadcrumbs: the parent entity-type and unique were being mixed up --- .../menu-variant-tree-structure-workspace-context-base.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts b/src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts index 1e483db90d..db207951b0 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts @@ -54,10 +54,10 @@ export abstract class UmbMenuVariantTreeStructureWorkspaceContextBase extends Um async #requestStructure() { const isNew = this.#workspaceContext?.getIsNew(); const uniqueObservable = isNew - ? this.#workspaceContext?._internal_createUnderParentEntityType + ? this.#workspaceContext?._internal_createUnderParentEntityUnique : this.#workspaceContext?.unique; const entityTypeObservable = isNew - ? this.#workspaceContext?._internal_createUnderParentEntityUnique + ? this.#workspaceContext?._internal_createUnderParentEntityType : this.#workspaceContext?.entityType; let structureItems: Array = []; @@ -112,7 +112,7 @@ export abstract class UmbMenuVariantTreeStructureWorkspaceContextBase extends Um } #setParentData(structureItems: Array) { - /* If the item is not new, the current item is the last item in the array. + /* If the item is not new, the current item is the last item in the array. We filter out the current item unique to handle any case where it could show up */ const parent = structureItems.filter((item) => item.unique !== this.#workspaceContext?.getUnique()).pop(); @@ -142,7 +142,7 @@ export abstract class UmbMenuVariantTreeStructureWorkspaceContextBase extends Um return entity; }) - /* If the item is not new, the current item is the last item in the array. + /* If the item is not new, the current item is the last item in the array. We filter out the current item unique to handle any case where it could show up */ .filter((item) => item.unique !== this.#workspaceContext?.getUnique());