From 3d3d249e7eecd7eeaebf75b8ef7275a1d91ed6a4 Mon Sep 17 00:00:00 2001 From: Shannon Date: Fri, 7 Dec 2018 13:13:00 +1100 Subject: [PATCH] adds notes --- src/Umbraco.Web/Editors/ContentController.cs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/Umbraco.Web/Editors/ContentController.cs b/src/Umbraco.Web/Editors/ContentController.cs index 53ecddd015..e330df1c45 100644 --- a/src/Umbraco.Web/Editors/ContentController.cs +++ b/src/Umbraco.Web/Editors/ContentController.cs @@ -1908,6 +1908,10 @@ namespace Umbraco.Web.Editors { case PublishResultType.SuccessPublishAlready: { + //TODO: Here we should have messaging for when there are release dates specified like https://github.com/umbraco/Umbraco-CMS/pull/3507 + // but this will take a bit of effort because we need to deal with variants, different messaging, etc... A quick attempt was made here: + // http://github.com/umbraco/Umbraco-CMS/commit/9b3de7b655e07c612c824699b48a533c0448131a + //special case, we will only show messages for this if: // * it's not a bulk publish operation // * it's a bulk publish operation and all successful statuses are this one @@ -1935,6 +1939,10 @@ namespace Umbraco.Web.Editors break; case PublishResultType.SuccessPublish: { + //TODO: Here we should have messaging for when there are release dates specified like https://github.com/umbraco/Umbraco-CMS/pull/3507 + // but this will take a bit of effort because we need to deal with variants, different messaging, etc... A quick attempt was made here: + // http://github.com/umbraco/Umbraco-CMS/commit/9b3de7b655e07c612c824699b48a533c0448131a + var itemCount = status.Count(); if (successfulCultures == null) {