From 3df85ff695e9ee06d2cd8f69d6a24791fd753018 Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Sun, 19 Nov 2023 12:51:53 +0100 Subject: [PATCH] update rule name --- src/Umbraco.Web.UI.Client/.eslintrc.json | 2 +- ...exported-const.cjs => exported-string-constant-naming.cjs} | 4 ++-- src/Umbraco.Web.UI.Client/eslint-local-rules.cjs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) rename src/Umbraco.Web.UI.Client/devops/eslint/rules/{prefix-exported-const.cjs => exported-string-constant-naming.cjs} (84%) diff --git a/src/Umbraco.Web.UI.Client/.eslintrc.json b/src/Umbraco.Web.UI.Client/.eslintrc.json index 46fae82ab9..6ccad7596e 100644 --- a/src/Umbraco.Web.UI.Client/.eslintrc.json +++ b/src/Umbraco.Web.UI.Client/.eslintrc.json @@ -51,7 +51,7 @@ "exceptions": ["@umbraco-cms", "@open-wc/testing", "@storybook", "msw", "."] } ], - "local-rules/prefix-exported-constants": ["error", + "local-rules/exported-string-constant-naming": ["error", { "excludedFileNames": ["umbraco-package", "input-tiny-mce.defaults"] // TODO: what to do about the tiny mce defaults? } diff --git a/src/Umbraco.Web.UI.Client/devops/eslint/rules/prefix-exported-const.cjs b/src/Umbraco.Web.UI.Client/devops/eslint/rules/exported-string-constant-naming.cjs similarity index 84% rename from src/Umbraco.Web.UI.Client/devops/eslint/rules/prefix-exported-const.cjs rename to src/Umbraco.Web.UI.Client/devops/eslint/rules/exported-string-constant-naming.cjs index 2b5662e4b5..264fdbbb24 100644 --- a/src/Umbraco.Web.UI.Client/devops/eslint/rules/prefix-exported-const.cjs +++ b/src/Umbraco.Web.UI.Client/devops/eslint/rules/exported-string-constant-naming.cjs @@ -3,7 +3,7 @@ module.exports = { type: 'problem', docs: { description: - 'Ensure all exported constants should be in uppercase with words separated by underscores and prefixed with UMB_', + 'Ensure all exported string constants should be in uppercase with words separated by underscores and prefixed with UMB_', }, }, create: function (context) { @@ -28,7 +28,7 @@ module.exports = { context.report({ node: id, message: - 'Exported constant should be in uppercase with words separated by underscores and prefixed with UMB_', + 'Exported string constant should be in uppercase with words separated by underscores and prefixed with UMB_', }); } } diff --git a/src/Umbraco.Web.UI.Client/eslint-local-rules.cjs b/src/Umbraco.Web.UI.Client/eslint-local-rules.cjs index f092b410a9..1f7e56aea0 100644 --- a/src/Umbraco.Web.UI.Client/eslint-local-rules.cjs +++ b/src/Umbraco.Web.UI.Client/eslint-local-rules.cjs @@ -18,5 +18,5 @@ module.exports = { 'prefer-import-aliases': preferImportAliasesRule, 'prefer-static-styles-last': preferStaticStylesLastRule, 'umb-class-prefix': umbClassPrefixRule, - 'prefix-exported-constants': require('./devops/eslint/rules/prefix-exported-const.cjs'), + 'exported-string-constant-naming': require('./devops/eslint/rules/exported-string-constant-naming.cjs'), };