From 3e422500dc2d6e5f88ed4ebc5c3b48e183513ee7 Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Thu, 4 Jul 2024 15:13:48 +0200 Subject: [PATCH] remove unused vars --- .../src/libs/observable-api/observer.controller.test.ts | 6 +++--- .../details/data-type-details-workspace-view.stories.ts | 2 +- .../views/info/workspace-view-data-type-info.stories.ts | 2 +- .../repository/item/dictionary-item.server.data-source.ts | 5 +---- .../src/packages/dictionary/tree/manifests.ts | 1 - .../tree/document-blueprint-tree.server.data-source.ts | 2 +- .../workspace/document-blueprint-workspace.context.ts | 1 - .../documents/documents/entity-actions/manifests.ts | 2 -- .../documents/documents/entity-bulk-actions/manifests.ts | 5 ----- .../media/media/entity-bulk-actions/move/move.action.ts | 4 ++-- .../media/modals/media-picker/media-picker-modal.element.ts | 2 +- .../media/repository/item/media-item.server.data-source.ts | 2 +- .../media/media/tree/media-tree.server.data-source.ts | 6 +----- .../src/packages/object-type/input-object-type.element.ts | 2 +- .../views/created/created-packages-section-view.element.ts | 2 +- .../tree/folder/stylesheet-folder.server.data-source.ts | 2 +- 16 files changed, 15 insertions(+), 31 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.controller.test.ts b/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.controller.test.ts index a8a140a5bc..5688539233 100644 --- a/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.controller.test.ts +++ b/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.controller.test.ts @@ -20,7 +20,7 @@ describe('UmbObserverController', () => { const state = new UmbObjectState(undefined); const observable = state.asObservable(); - const callbackMethod = (state: unknown) => {}; + const callbackMethod = () => {}; const firstCtrl = new UmbObserverController(hostElement, observable, callbackMethod, 'my-test-alias'); const secondCtrl = new UmbObserverController(hostElement, observable, callbackMethod, 'my-test-alias'); @@ -33,7 +33,7 @@ describe('UmbObserverController', () => { const state = new UmbObjectState(undefined); const observable = state.asObservable(); - const callbackMethod = (state: unknown) => {}; + const callbackMethod = () => {}; const mySymbol = Symbol(); const firstCtrl = new UmbObserverController(hostElement, observable, callbackMethod, mySymbol); @@ -47,7 +47,7 @@ describe('UmbObserverController', () => { const state = new UmbObjectState(undefined); const observable = state.asObservable(); - const callbackMethod = (state: unknown) => {}; + const callbackMethod = () => {}; // Imitates the behavior of the observe method in the UmbClassMixin let controllerAlias1 = null; diff --git a/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/details/data-type-details-workspace-view.stories.ts b/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/details/data-type-details-workspace-view.stories.ts index a0ea45dfca..8acf0b7488 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/details/data-type-details-workspace-view.stories.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/details/data-type-details-workspace-view.stories.ts @@ -12,7 +12,7 @@ export default { component: 'umb-data-type-workspace-view-edit', id: 'umb-data-type-workspace-view-edit', decorators: [ - (story) => { + () => { return html`TODO: make use of mocked workspace context??`; /*html` ${story()} diff --git a/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/info/workspace-view-data-type-info.stories.ts b/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/info/workspace-view-data-type-info.stories.ts index 01580af33f..5101c961a2 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/info/workspace-view-data-type-info.stories.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/views/info/workspace-view-data-type-info.stories.ts @@ -12,7 +12,7 @@ export default { component: 'umb-workspace-view-data-type-info', id: 'umb-workspace-view-data-type-info', decorators: [ - (story) => { + () => { return html`TODO: make use of mocked workspace context??`; /*html` ${story()} diff --git a/src/Umbraco.Web.UI.Client/src/packages/dictionary/repository/item/dictionary-item.server.data-source.ts b/src/Umbraco.Web.UI.Client/src/packages/dictionary/repository/item/dictionary-item.server.data-source.ts index b9293d6afb..2ef2a48490 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/dictionary/repository/item/dictionary-item.server.data-source.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/dictionary/repository/item/dictionary-item.server.data-source.ts @@ -1,10 +1,7 @@ import { UMB_DICTIONARY_ENTITY_TYPE } from '../../entity.js'; import type { UmbDictionaryItemModel } from './types.js'; import { UmbItemServerDataSourceBase } from '@umbraco-cms/backoffice/repository'; -import type { - DictionaryItemItemResponseModel, - DictionaryItemResponseModel, -} from '@umbraco-cms/backoffice/external/backend-api'; +import type { DictionaryItemItemResponseModel } from '@umbraco-cms/backoffice/external/backend-api'; import { DictionaryService } from '@umbraco-cms/backoffice/external/backend-api'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; diff --git a/src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/manifests.ts index 9b38b4f6fd..93f0f644c4 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/manifests.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/manifests.ts @@ -4,7 +4,6 @@ import { UMB_DICTIONARY_TREE_REPOSITORY_ALIAS, UMB_DICTIONARY_TREE_STORE_ALIAS, } from './constants.js'; -import { UmbDictionaryTreeStore } from './dictionary-tree.store.js'; import { manifests as reloadTreeItemChildrenManifests } from './reload-tree-item-children/manifests.js'; import type { ManifestRepository, diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/document-blueprint-tree.server.data-source.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/document-blueprint-tree.server.data-source.ts index e9916b6a8b..eddbd1fb5c 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/document-blueprint-tree.server.data-source.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/document-blueprint-tree.server.data-source.ts @@ -59,7 +59,7 @@ const getChildrenOf = (args: UmbTreeChildrenOfRequestArgs) => { } }; -const getAncestorsOf = (args: UmbTreeAncestorsOfRequestArgs) => { +const getAncestorsOf = () => { throw new Error('Not implemented'); /** TODO: Implement when endpoint becomes available... */ }; diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace.context.ts index 5a56cca1b0..aa48c508c8 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace.context.ts @@ -16,7 +16,6 @@ import { import { UmbSubmittableWorkspaceContextBase, UmbWorkspaceIsNewRedirectController, - UmbWorkspaceRouteManager, UmbWorkspaceSplitViewManager, } from '@umbraco-cms/backoffice/workspace'; import { UmbContentTypeStructureManager } from '@umbraco-cms/backoffice/content-type'; diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts index e19caad085..4800606d69 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts @@ -2,8 +2,6 @@ import { UMB_DOCUMENT_DETAIL_REPOSITORY_ALIAS, UMB_DOCUMENT_ITEM_REPOSITORY_ALIA import { UMB_DOCUMENT_ENTITY_TYPE } from '../entity.js'; import { UMB_USER_PERMISSION_DOCUMENT_DELETE, - UMB_USER_PERMISSION_DOCUMENT_NOTIFICATIONS, - UMB_USER_PERMISSION_DOCUMENT_PERMISSIONS, UMB_USER_PERMISSION_DOCUMENT_PUBLISH, UMB_USER_PERMISSION_DOCUMENT_UNPUBLISH, } from '../user-permissions/constants.js'; diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-bulk-actions/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-bulk-actions/manifests.ts index de206ceb60..1ea725ee64 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-bulk-actions/manifests.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-bulk-actions/manifests.ts @@ -1,10 +1,5 @@ import { UMB_DOCUMENT_COLLECTION_ALIAS } from '../collection/index.js'; import { UMB_DOCUMENT_ENTITY_TYPE } from '../entity.js'; -import { UmbDocumentDuplicateEntityBulkAction } from './duplicate/duplicate.action.js'; -import { UmbDocumentDeleteEntityBulkAction } from './delete/delete.action.js'; -import { UmbMoveDocumentEntityBulkAction } from './move/move.action.js'; -import { UmbDocumentPublishEntityBulkAction } from './publish/publish.action.js'; -import { UmbDocumentUnpublishEntityBulkAction } from './unpublish/unpublish.action.js'; import type { UmbCollectionBulkActionPermissions } from '@umbraco-cms/backoffice/collection'; import type { ManifestEntityBulkAction } from '@umbraco-cms/backoffice/extension-registry'; import { diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-bulk-actions/move/move.action.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-bulk-actions/move/move.action.ts index d22ef9c539..e227b89b8c 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-bulk-actions/move/move.action.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-bulk-actions/move/move.action.ts @@ -15,8 +15,8 @@ export class UmbMediaMoveEntityBulkAction extends UmbEntityBulkActionBase { + this.#repository.read().then(({ data }) => { if (!data) return; this._options = data.items.map((item) => ({ value: item.id, name: item.name ?? '' })); diff --git a/src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/created/created-packages-section-view.element.ts b/src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/created/created-packages-section-view.element.ts index d19f3286d2..c3dd0a5746 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/created/created-packages-section-view.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/created/created-packages-section-view.element.ts @@ -49,7 +49,7 @@ export class UmbCreatedPackagesSectionViewElement extends UmbLitElement implemen routes.push({ path: workspace.meta.entityType, component: () => createExtensionElement(workspace), - setup: (component, info) => { + setup: (component) => { if (component) { (component as any).workspaceAlias = workspace.alias; } diff --git a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/folder/stylesheet-folder.server.data-source.ts b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/folder/stylesheet-folder.server.data-source.ts index 24ba1fb4fc..43356b7179 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/folder/stylesheet-folder.server.data-source.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/folder/stylesheet-folder.server.data-source.ts @@ -109,7 +109,7 @@ export class UmbStylesheetFolderServerDataSource implements UmbFolderDataSource ); } - async update(args: UmbUpdateFolderModel): Promise { + async update(): Promise { throw new Error('Updating is not supported'); } }