diff --git a/src/Umbraco.Web.Common/Filters/HttpResponseExceptionFilter.cs b/src/Umbraco.Web.Common/Filters/HttpResponseExceptionFilter.cs index cd2d2cb3a0..46bfd6cdfa 100644 --- a/src/Umbraco.Web.Common/Filters/HttpResponseExceptionFilter.cs +++ b/src/Umbraco.Web.Common/Filters/HttpResponseExceptionFilter.cs @@ -7,11 +7,6 @@ namespace Umbraco.Web.Common.Filters { public class HttpResponseExceptionFilter : IActionFilter, IOrderedFilter { - public HttpResponseExceptionFilter() - { - - } - public int Order { get; set; } = int.MaxValue - 10; public void OnActionExecuting(ActionExecutingContext context) { } diff --git a/src/Umbraco.Web.UI.Client/src/installer/installer.service.js b/src/Umbraco.Web.UI.Client/src/installer/installer.service.js index 1003b19b20..8658e6e67e 100644 --- a/src/Umbraco.Web.UI.Client/src/installer/installer.service.js +++ b/src/Umbraco.Web.UI.Client/src/installer/installer.service.js @@ -340,6 +340,7 @@ angular.module("umbraco.install").factory('installerService', function ($rootSco // TODO: In dotnetcore the resulting YSOD isn't HTML, the error is just a string so it looks ugly // So we shouldn't be using an iframe and will need to change this so that we have an unhandled exception filter for the installer (and eventually // the rest of the back office) to handle errors and chuck the data into a json format for us to use. + // It might turn out that our new Api Convention `UmbracoApiBehaviorApplicationModelProvider` might handle this for us with it's custom error handling. $timeout(function () { document.getElementById('ysod').contentDocument.write(ysod); }, 500);