From 420746397dbfdf0976880b9ee95d899c2f5f9fe8 Mon Sep 17 00:00:00 2001 From: Shannon Date: Sat, 17 May 2014 15:35:56 +1000 Subject: [PATCH] fixes macro property saving issue in editor (to ensure the alias/key can be changed) --- .../umbraco/developer/Macros/editMacro.aspx.cs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Macros/editMacro.aspx.cs b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Macros/editMacro.aspx.cs index a50c2970de..50fb8b912e 100644 --- a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Macros/editMacro.aspx.cs +++ b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Macros/editMacro.aspx.cs @@ -322,8 +322,6 @@ namespace umbraco.cms.presentation.developer void Save_Click(object sender, EventArgs e) { - //disable the add validators - macroProperties. Page.Validate(); @@ -351,10 +349,14 @@ namespace umbraco.cms.presentation.developer var macroElementType = (DropDownList)item.FindControl("macroPropertyType"); var prop = _macro.Properties.Single(x => x.Id == int.Parse(macroPropertyId.Value)); - prop.Alias = macroElementAlias.Text.Trim(); - prop.Name = macroElementName.Text.Trim(); - prop.EditorAlias = macroElementType.SelectedValue; - prop.SortOrder = sort; + + _macro.Properties.UpdateProperty( + prop.Alias, + macroElementName.Text.Trim(), + sort, + macroElementType.SelectedValue, + macroElementAlias.Text.Trim()); + sort++; }