yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Integration Tests: Use empty temp folder for legacy lang config when using integration tests outside core (closes #20888) (#20889)

Browse Source 
* Use empty folder under temp as localized text source folder in non umbraco core integration tests.

* Added clarifying comment to the GetLocalizedTextService override for tests
This commit is contained in:
Lars-Erik Aabech
2025-11-20 06:54:35 +01:00
committed by GitHub
parent 61a5d26a93
commit 43bdad59b6
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/Umbraco.Tests.Integration/DependencyInjection/UmbracoBuilderExtensions.cs
View File

@@ -125,18 +125,15 @@ public static class UmbracoBuilderExtensions
if (!currFolder.Exists) if (!currFolder.Exists)
{ {
currFolder = new DirectoryInfo(Path.GetTempPath()); // When Umbraco.Integration.Tests is installed in a "consumer" Umbraco site, the src/tests path might not be there.
// This replaces the folder reference with an empty folder under temp
// such that the LocalizedTextServiceFileSources don't blow up from directory not found,
// or reading random xml files from the base temp folder.
var tempPath = Path.GetTempPath();
currFolder = new DirectoryInfo(Path.GetFullPath("Umbraco.Integration.Tests.Fake.SrcRoot", tempPath));
currFolder.Create();
} }
var uiProject = currFolder.GetDirectories("Umbraco.Web.UI", SearchOption.TopDirectoryOnly).FirstOrDefault();
if (uiProject == null)
{
uiProject = new DirectoryInfo(Path.Combine(Path.GetTempPath(), "Umbraco.Web.UI"));
uiProject.Create();
}
var mainLangFolder = new DirectoryInfo(Path.Combine(uiProject.FullName, Constants.System.DefaultUmbracoPath.TrimStart(Constants.CharArrays.TildeForwardSlash), "config", "lang"));
return new LocalizedTextServiceFileSources( return new LocalizedTextServiceFileSources(
loggerFactory.CreateLogger<LocalizedTextServiceFileSources>(), loggerFactory.CreateLogger<LocalizedTextServiceFileSources>(),
appCaches, appCaches,