From 4478d2239098d06c431faee708cf9932ef650716 Mon Sep 17 00:00:00 2001
From: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
Date: Fri, 31 May 2024 13:02:43 +0200
Subject: [PATCH] Add retries to flaky tests (#16529)

---
 .../BackOfficeExamineSearcherTests.cs              | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tests/Umbraco.Tests.Integration/Umbraco.Examine.Lucene/UmbracoExamine/BackOfficeExamineSearcherTests.cs b/tests/Umbraco.Tests.Integration/Umbraco.Examine.Lucene/UmbracoExamine/BackOfficeExamineSearcherTests.cs
index e7d8ebbdb2..2bc60dcd59 100644
--- a/tests/Umbraco.Tests.Integration/Umbraco.Examine.Lucene/UmbracoExamine/BackOfficeExamineSearcherTests.cs
+++ b/tests/Umbraco.Tests.Integration/Umbraco.Examine.Lucene/UmbracoExamine/BackOfficeExamineSearcherTests.cs
@@ -160,6 +160,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Published_Content_With_Empty_Query()
     {
         await SetupUserIdentity(Constants.Security.SuperUserIdAsString);
@@ -178,6 +179,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Published_Content_With_Query_By_Content_Name()
     {
         // Arrange
@@ -198,6 +200,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Published_Content_With_Query_By_Non_Existing_Content_Name()
     {
         // Arrange
@@ -215,6 +218,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Published_Content_With_Query_By_Content_Id()
     {
         // Arrange
@@ -238,6 +242,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Two_Published_Content_With_Similar_Names_By_Name()
     {
         // Arrange
@@ -298,6 +303,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_For_Child_Published_Content_With_Query_By_Content_Name()
     {
         // Arrange
@@ -360,6 +366,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_For_Child_In_Child_Published_Content_With_Query_By_Content_Name()
     {
         // Arrange
@@ -444,6 +451,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Published_Content_With_Query_With_Content_Name_No_User_Logged_In()
     {
         // Arrange
@@ -462,6 +470,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
 
     // Multiple Languages
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Published_Content_By_Content_Name_With_Two_Languages()
     {
         // Arrange
@@ -515,6 +524,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_For_Published_Content_Name_With_Two_Languages_By_Default_Language_Content_Name()
     {
         // Arrange
@@ -540,6 +550,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_For_Published_Content_Name_With_Two_Languages_By_Non_Default_Language_Content_Name()
     {
         // Arrange
@@ -565,6 +576,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Search_Published_Content_With_Two_Languages_By_Id()
     {
         // Arrange
@@ -591,6 +603,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
 
     // Check All Indexed Values
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Check_All_Indexed_Values_For_Published_Content_With_No_Properties()
     {
         // Arrange
@@ -657,6 +670,7 @@ public class BackOfficeExamineSearcherTests : ExamineBaseTest
     }
 
     [Test]
+    [Retry(5)] // TODO make this test non-flaky.
     public async Task Check_All_Indexed_Values_For_Published_Content_With_Properties()
     {
         // Arrange