From 44ec0e66d9b95729670968368b566065b6165768 Mon Sep 17 00:00:00 2001
From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
Date: Wed, 27 Nov 2024 12:22:36 +0100
Subject: [PATCH] V15: Debug missing contexts (#17645)

* fix: wait a frame before calculating events, which allows the debug callback to "fill up" the instances map

* Revert "fix: wait a frame before calculating events, which allows the debug callback to "fill up" the instances map"

This reverts commit a8a2bdbb053866ee88d35d076dd897bdf0a65826.

* fix: assign the inner object (`event.instances`) directly to a state and perform the "massaging" only when it updates

this ensures that any live changes to the inner object are reflected in the UI
---
 .../src/packages/core/debug/debug.element.ts        | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/debug/debug.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/debug/debug.element.ts
index 418b07fbc9..c2144dec62 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/core/debug/debug.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/core/debug/debug.element.ts
@@ -3,7 +3,7 @@ import { css, customElement, html, map, nothing, property, state, when } from '@
 import { contextData, UmbContextDebugRequest } from '@umbraco-cms/backoffice/context-api';
 import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
 import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
-import type { UmbDebugContextData, UmbDebugContextItemData } from '@umbraco-cms/backoffice/context-api';
+import type { UmbDebugContextItemData } from '@umbraco-cms/backoffice/context-api';
 import type { UmbModalManagerContext } from '@umbraco-cms/backoffice/modal';
 
 @customElement('umb-debug')
@@ -15,7 +15,7 @@ export class UmbDebugElement extends UmbLitElement {
 	dialog = false;
 
 	@state()
-	private _contextData = Array<UmbDebugContextData>();
+	private _contexts = new Map<any, any>();
 
 	@state()
 	private _debugPaneOpen = false;
@@ -37,11 +37,7 @@ export class UmbDebugElement extends UmbLitElement {
 				// to the root of <umb-app> which then uses the callback prop
 				// of this event that has been raised to assign the contexts
 				// back to this property of the WebComponent
-
-				// Massage the data into a simplier array of objects
-				// from a function in the context-api.
-				this._contextData = contextData(contexts);
-				this.requestUpdate('_contextData');
+				this._contexts = contexts;
 			}),
 		);
 	}
@@ -92,8 +88,9 @@ export class UmbDebugElement extends UmbLitElement {
 	}
 
 	#renderContextAliases() {
+		const data = contextData(this._contexts);
 		return html`<div class="events">
-			${map(this._contextData, (context) => {
+			${map(data, (context) => {
 				return html`
 					<details>
 						<summary><strong>${context.alias}</strong></summary>