From 45cb56b96c1b0cbbe0adb0a4c0fccc38010761dc Mon Sep 17 00:00:00 2001
From: Stephan <stephane@umbraco.dk>
Date: Fri, 26 Oct 2018 12:36:59 +0200
Subject: [PATCH] Fix ContentCultureInfos and collection

---
 src/Umbraco.Core/Models/ContentCultureInfos.cs         | 10 +++++-----
 .../Models/ContentCultureInfosCollection.cs            |  6 +++++-
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/Umbraco.Core/Models/ContentCultureInfos.cs b/src/Umbraco.Core/Models/ContentCultureInfos.cs
index bcf1dbb1b1..f51e3a275a 100644
--- a/src/Umbraco.Core/Models/ContentCultureInfos.cs
+++ b/src/Umbraco.Core/Models/ContentCultureInfos.cs
@@ -28,11 +28,11 @@ namespace Umbraco.Core.Models
         /// Initializes a new instance of the <see cref="ContentCultureInfos"/> class.
         /// </summary>
         /// <remarks>Used for cloning, without change tracking.</remarks>
-        private ContentCultureInfos(string culture, string name, DateTime date)
-            : this(culture)
+        internal ContentCultureInfos(ContentCultureInfos other)
+            : this(other.Culture)
         {
-            _name = name;
-            _date = date;
+            _name = other.Name;
+            _date = other.Date;
         }
 
         /// <summary>
@@ -61,7 +61,7 @@ namespace Umbraco.Core.Models
         /// <inheritdoc />
         public object DeepClone()
         {
-            return new ContentCultureInfos(Culture, Name, Date);
+            return new ContentCultureInfos(this);
         }
 
         /// <inheritdoc />
diff --git a/src/Umbraco.Core/Models/ContentCultureInfosCollection.cs b/src/Umbraco.Core/Models/ContentCultureInfosCollection.cs
index 5238e65631..82b0ba6475 100644
--- a/src/Umbraco.Core/Models/ContentCultureInfosCollection.cs
+++ b/src/Umbraco.Core/Models/ContentCultureInfosCollection.cs
@@ -24,8 +24,12 @@ namespace Umbraco.Core.Models
         public ContentCultureInfosCollection(IEnumerable<ContentCultureInfos> items)
             : base(x => x.Culture, StringComparer.InvariantCultureIgnoreCase)
         {
+            // make sure to add *copies* and not the original items,
+            // as items can be modified by AddOrUpdate, and therefore
+            // the new collection would be impacted by changes made
+            // to the old collection
             foreach (var item in items)
-                Add(item);
+                Add(new ContentCultureInfos(item));
         }
         
         /// <summary>