From 45fa296f2557eefdb481db2e6927bf454d32aa0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Mon, 28 Aug 2023 12:57:38 +0200 Subject: [PATCH] controller aliases --- .../collection-selection-actions.element.ts | 5 +++-- .../variant-dataset-context.interface.ts | 12 +++++++++++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/collection/collection-selection-actions.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/collection/collection-selection-actions.element.ts index 06bd7ab183..2e13b18f2a 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/collection/collection-selection-actions.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/collection/collection-selection-actions.element.ts @@ -51,12 +51,12 @@ export class UmbCollectionSelectionActionsElement extends UmbLitElement { // TODO: Make sure it only updates on length change. this.observe(this._collectionContext.items, (mediaItems) => { this._nodesLength = mediaItems.length; - }); + }, 'observeItem'); this.observe(this._collectionContext.selection, (selection) => { this._selectionLength = selection.length; this._selection = selection; - }); + }, 'observeSelection'); } private _renderSelectionCount() { @@ -74,6 +74,7 @@ export class UmbCollectionSelectionActionsElement extends UmbLitElement { (bulkActions) => { this._entityBulkActions = bulkActions; } + , 'observeEntityBulkActions' ); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/workspace/dataset-context/variant-dataset-context.interface.ts b/src/Umbraco.Web.UI.Client/src/packages/core/workspace/dataset-context/variant-dataset-context.interface.ts index 8eb2a0b20b..8877aa085b 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/workspace/dataset-context/variant-dataset-context.interface.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/workspace/dataset-context/variant-dataset-context.interface.ts @@ -1,7 +1,17 @@ import { UmbDatasetContext } from "./dataset-context.interface.js"; import { UmbVariantId } from "@umbraco-cms/backoffice/variant"; - +/** + * A dataset context for a variant. + * + * @notes + * This one will depending on the origin of such deliver: + * - name + * - a variant id + * - a workspace reference + * - save state (this should depend on the workspace, this will become another superset of the dataset) + * - publish state (this should depend on the workspace, this will become another superset of the dataset) +*/ export interface UmbVariantDatasetContext extends UmbDatasetContext { getVariantId: () => UmbVariantId; }