yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changes a couple of collection builders to not use the lazy (slightly more expensive ones) when not needed.

Browse Source
This commit is contained in:
Shannon
2021-07-12 13:34:14 -06:00
parent 11b0157047
commit 461a199d15
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Umbraco.Core/Composing/LazyCollectionBuilderBase.cs
View File

@@ -10,6 +10,9 @@ namespace Umbraco.Cms.Core.Composing
/// <typeparam name="TBuilder">The type of the builder.</typeparam>
/// <typeparam name="TCollection">The type of the collection.</typeparam>
/// <typeparam name="TItem">The type of the items.</typeparam>
/// <remarks>
/// This type of collection builder is typically used when type scanning is required (i.e. plugins).
/// </remarks>
public abstract class LazyCollectionBuilderBase<TBuilder, TCollection, TItem> : CollectionBuilderBase<TBuilder, TCollection, TItem>
where TBuilder : LazyCollectionBuilderBase<TBuilder, TCollection, TItem>
where TCollection : class, IBuilderCollection<TItem>
@@ -29,7 +32,7 @@ namespace Umbraco.Cms.Core.Composing
{
types.Clear();
_producers.Clear();
_excluded.Clear();
_excluded.Clear();
});
return This;
}
@@ -45,7 +48,8 @@ namespace Umbraco.Cms.Core.Composing
Configure(types =>
{
var type = typeof(T);
if (types.Contains(type) == false) types.Add(type);
if (types.Contains(type) == false)
types.Add(type);
});
return This;
}
@@ -60,7 +64,8 @@ namespace Umbraco.Cms.Core.Composing
Configure(types =>
{
EnsureType(type, "register");
if (types.Contains(type) == false) types.Add(type);
if (types.Contains(type) == false)
types.Add(type);
});
return This;
}
@@ -90,7 +95,8 @@ namespace Umbraco.Cms.Core.Composing
Configure(types =>
{
var type = typeof(T);
if (_excluded.Contains(type) == false) _excluded.Add(type);
if (_excluded.Contains(type) == false)
_excluded.Add(type);
});
return This;
}
@@ -105,7 +111,8 @@ namespace Umbraco.Cms.Core.Composing
Configure(types =>
{
EnsureType(type, "exclude");
if (_excluded.Contains(type) == false) _excluded.Add(type);
if (_excluded.Contains(type) == false)
_excluded.Add(type);
});
return This;
}