yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added 'mandatory' tag as a visual indicator for webhook events being … (#21075)

Browse Source 
* Added 'mandatory' tag as a visual indicator for webhook events being mandatory.

* Map the webhook validation for no events specified to a specific API response problem details message.

---------

Co-authored-by: Andy Butland <abutland73@gmail.com>
This commit is contained in:
Eric
2025-12-05 16:44:33 +01:00
committed by GitHub
parent 830250b682
commit 475010148b
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Umbraco.Cms.Api.Management/Controllers/Webhook/WebhookControllerBase.cs
View File

@@ -21,6 +21,10 @@ public abstract class WebhookControllerBase : ManagementApiControllerBase
.WithTitle("Cancelled by notification") .WithTitle("Cancelled by notification")
.WithDetail("A notification handler prevented the webhook operation.") .WithDetail("A notification handler prevented the webhook operation.")
.Build()), .Build()),
WebhookOperationStatus.NoEvents => BadRequest(new ProblemDetailsBuilder()
.WithTitle("No events specified")
.WithDetail("The webhook must be configured to listen to at least one event.")
.Build()),
_ => StatusCode(StatusCodes.Status500InternalServerError, new ProblemDetailsBuilder() _ => StatusCode(StatusCodes.Status500InternalServerError, new ProblemDetailsBuilder()
.WithTitle("Unknown webhook operation status.") .WithTitle("Unknown webhook operation status.")
.Build()), .Build()),

6
src/Umbraco.Web.UI.Client/src/packages/webhook/webhook/workspace/views/webhook-details-workspace-view.element.ts
View File

@@ -107,9 +107,13 @@ export class UmbWebhookDetailsWorkspaceViewElement extends UmbLitElement impleme
mandatory mandatory
label=${this.localize.term('webhooks_url')} label=${this.localize.term('webhooks_url')}
description=${this.localize.term('webhooks_urlDescription')}> description=${this.localize.term('webhooks_urlDescription')}>
<uui-input @input=${this.#onUrlChange} .value=${this._webhook.url} slot="editor" required="true"></uui-input> <uui-input
@input=${this.#onUrlChange}
.value=${this._webhook.url}
slot="editor" required="true"></uui-input>
</umb-property-layout> </umb-property-layout>
<umb-property-layout <umb-property-layout
mandatory
label=${this.localize.term('webhooks_events')} label=${this.localize.term('webhooks_events')}
description=${this.localize.term('webhooks_eventDescription')}> description=${this.localize.term('webhooks_eventDescription')}>
<umb-input-webhook-events <umb-input-webhook-events