diff --git a/src/Umbraco.Core/Migrations/Install/DatabaseBuilder.cs b/src/Umbraco.Core/Migrations/Install/DatabaseBuilder.cs
index cf4dd923de..533c6cbbe7 100644
--- a/src/Umbraco.Core/Migrations/Install/DatabaseBuilder.cs
+++ b/src/Umbraco.Core/Migrations/Install/DatabaseBuilder.cs
@@ -29,13 +29,23 @@ namespace Umbraco.Core.Migrations.Install
private readonly IKeyValueService _keyValueService;
private readonly ILogger _logger;
private readonly IIOHelper _ioHelper;
+ private readonly IUmbracoVersion _umbracoVersion;
private DatabaseSchemaResult _databaseSchemaValidationResult;
///
/// Initializes a new instance of the class.
///
- public DatabaseBuilder(IScopeProvider scopeProvider, IGlobalSettings globalSettings, IUmbracoDatabaseFactory databaseFactory, IRuntimeState runtime, ILogger logger, IMigrationBuilder migrationBuilder, IKeyValueService keyValueService, IIOHelper ioHelper)
+ public DatabaseBuilder(
+ IScopeProvider scopeProvider,
+ IGlobalSettings globalSettings,
+ IUmbracoDatabaseFactory databaseFactory,
+ IRuntimeState runtime,
+ ILogger logger,
+ IMigrationBuilder migrationBuilder,
+ IKeyValueService keyValueService,
+ IIOHelper ioHelper,
+ IUmbracoVersion umbracoVersion)
{
_scopeProvider = scopeProvider;
_globalSettings = globalSettings;
@@ -45,6 +55,7 @@ namespace Umbraco.Core.Migrations.Install
_migrationBuilder = migrationBuilder;
_keyValueService = keyValueService;
_ioHelper = ioHelper;
+ _umbracoVersion = umbracoVersion;
}
#region Status
@@ -369,7 +380,7 @@ namespace Umbraco.Core.Migrations.Install
return _databaseSchemaValidationResult;
var database = scope.Database;
- var dbSchema = new DatabaseSchemaCreator(database, _logger);
+ var dbSchema = new DatabaseSchemaCreator(database, _logger, _umbracoVersion);
_databaseSchemaValidationResult = dbSchema.ValidateSchema();
scope.Complete();
return _databaseSchemaValidationResult;
@@ -419,7 +430,7 @@ namespace Umbraco.Core.Migrations.Install
if (_runtime.Level == RuntimeLevel.Run)
throw new Exception("Umbraco is already configured!");
- var creator = new DatabaseSchemaCreator(database, _logger);
+ var creator = new DatabaseSchemaCreator(database, _logger, _umbracoVersion);
creator.InitializeDatabaseSchema();
message = message + "
Installation completed!
";
diff --git a/src/Umbraco.Core/Migrations/Install/DatabaseDataCreator.cs b/src/Umbraco.Core/Migrations/Install/DatabaseDataCreator.cs
index 94d8cfbc62..5dc937822b 100644
--- a/src/Umbraco.Core/Migrations/Install/DatabaseDataCreator.cs
+++ b/src/Umbraco.Core/Migrations/Install/DatabaseDataCreator.cs
@@ -15,11 +15,13 @@ namespace Umbraco.Core.Migrations.Install
{
private readonly IDatabase _database;
private readonly ILogger _logger;
+ private readonly IUmbracoVersion _umbracoVersion;
- public DatabaseDataCreator(IDatabase database, ILogger logger)
+ public DatabaseDataCreator(IDatabase database, ILogger logger, IUmbracoVersion umbracoVersion)
{
_database = database;
_logger = logger;
+ _umbracoVersion = umbracoVersion;
}
///
@@ -324,7 +326,7 @@ namespace Umbraco.Core.Migrations.Install
{
// on install, initialize the umbraco migration plan with the final state
- var upgrader = new Upgrader(new UmbracoPlan());
+ var upgrader = new Upgrader(new UmbracoPlan(_umbracoVersion));
var stateValueKey = upgrader.StateValueKey;
var finalState = upgrader.Plan.FinalState;
diff --git a/src/Umbraco.Core/Migrations/Install/DatabaseSchemaCreator.cs b/src/Umbraco.Core/Migrations/Install/DatabaseSchemaCreator.cs
index eab7afe308..7181460eeb 100644
--- a/src/Umbraco.Core/Migrations/Install/DatabaseSchemaCreator.cs
+++ b/src/Umbraco.Core/Migrations/Install/DatabaseSchemaCreator.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using NPoco;
+using Umbraco.Core.Configuration;
using Umbraco.Core.Events;
using Umbraco.Core.Logging;
using Umbraco.Core.Persistence;
@@ -18,11 +19,13 @@ namespace Umbraco.Core.Migrations.Install
{
private readonly IUmbracoDatabase _database;
private readonly ILogger _logger;
+ private readonly IUmbracoVersion _umbracoVersion;
- public DatabaseSchemaCreator(IUmbracoDatabase database, ILogger logger)
+ public DatabaseSchemaCreator(IUmbracoDatabase database, ILogger logger, IUmbracoVersion umbracoVersion)
{
_database = database;
_logger = logger;
+ _umbracoVersion = umbracoVersion;
}
private ISqlSyntaxProvider SqlSyntax => _database.SqlContext.SqlSyntax;
@@ -125,7 +128,7 @@ namespace Umbraco.Core.Migrations.Install
if (e.Cancel == false)
{
- var dataCreation = new DatabaseDataCreator(_database, _logger);
+ var dataCreation = new DatabaseDataCreator(_database, _logger,_umbracoVersion);
foreach (var table in OrderedTables)
CreateTable(false, table, dataCreation);
}
@@ -395,7 +398,7 @@ namespace Umbraco.Core.Migrations.Install
where T : new()
{
var tableType = typeof(T);
- CreateTable(overwrite, tableType, new DatabaseDataCreator(_database, _logger));
+ CreateTable(overwrite, tableType, new DatabaseDataCreator(_database, _logger, _umbracoVersion));
}
///
diff --git a/src/Umbraco.Core/Migrations/Upgrade/UmbracoPlan.cs b/src/Umbraco.Core/Migrations/Upgrade/UmbracoPlan.cs
index 070f4bdf6a..c657d0d9e7 100644
--- a/src/Umbraco.Core/Migrations/Upgrade/UmbracoPlan.cs
+++ b/src/Umbraco.Core/Migrations/Upgrade/UmbracoPlan.cs
@@ -14,16 +14,16 @@ namespace Umbraco.Core.Migrations.Upgrade
///
public class UmbracoPlan : MigrationPlan
{
+ private readonly IUmbracoVersion _umbracoVersion;
private const string InitPrefix = "{init-";
private const string InitSuffix = "}";
-
- private IUmbracoVersion UmbracoVersion => Current.UmbracoVersion;
///
/// Initializes a new instance of the class.
///
- public UmbracoPlan()
+ public UmbracoPlan(IUmbracoVersion umbracoVersion)
: base(Constants.System.UmbracoUpgradePlanName)
{
+ _umbracoVersion = umbracoVersion;
DefinePlan();
}
@@ -66,13 +66,13 @@ namespace Umbraco.Core.Migrations.Upgrade
throw new InvalidOperationException($"Could not get current version from web.config {Constants.AppSettings.ConfigurationStatus} appSetting.");
// cannot go back in time
- if (currentVersion > UmbracoVersion.SemanticVersion)
- throw new InvalidOperationException($"Version {currentVersion} cannot be downgraded to {UmbracoVersion.SemanticVersion}.");
+ if (currentVersion > _umbracoVersion.SemanticVersion)
+ throw new InvalidOperationException($"Version {currentVersion} cannot be downgraded to {_umbracoVersion.SemanticVersion}.");
// only from 7.14.0 and above
var minVersion = new SemVersion(7, 14);
if (currentVersion < minVersion)
- throw new InvalidOperationException($"Version {currentVersion} cannot be migrated to {UmbracoVersion.SemanticVersion}."
+ throw new InvalidOperationException($"Version {currentVersion} cannot be migrated to {_umbracoVersion.SemanticVersion}."
+ $" Please upgrade first to at least {minVersion}.");
// Force versions between 7.14.*-7.15.* into into 7.14 initial state. Because there is no db-changes,
@@ -89,7 +89,7 @@ namespace Umbraco.Core.Migrations.Upgrade
{
if (TryGetInitStateVersion(state, out var initVersion))
{
- throw new InvalidOperationException($"Version {UmbracoVersion.SemanticVersion} does not support migrating from {initVersion}."
+ throw new InvalidOperationException($"Version {_umbracoVersion.SemanticVersion} does not support migrating from {initVersion}."
+ $" Please verify which versions support migrating from {initVersion}.");
}
diff --git a/src/Umbraco.Core/RuntimeState.cs b/src/Umbraco.Core/RuntimeState.cs
index e0ce17f769..42a48579df 100644
--- a/src/Umbraco.Core/RuntimeState.cs
+++ b/src/Umbraco.Core/RuntimeState.cs
@@ -249,7 +249,7 @@ namespace Umbraco.Core
protected virtual bool EnsureUmbracoUpgradeState(IUmbracoDatabaseFactory databaseFactory, ILogger logger)
{
- var upgrader = new Upgrader(new UmbracoPlan());
+ var upgrader = new Upgrader(new UmbracoPlan(_umbracoVersion));
var stateValueKey = upgrader.StateValueKey;
// no scope, no service - just directly accessing the database
diff --git a/src/Umbraco.Tests.Benchmarks/BulkInsertBenchmarks.cs b/src/Umbraco.Tests.Benchmarks/BulkInsertBenchmarks.cs
index dc260c4a3b..aab1528987 100644
--- a/src/Umbraco.Tests.Benchmarks/BulkInsertBenchmarks.cs
+++ b/src/Umbraco.Tests.Benchmarks/BulkInsertBenchmarks.cs
@@ -5,6 +5,7 @@ using System.IO;
using System.Linq;
using BenchmarkDotNet.Attributes;
using Umbraco.Core;
+using Umbraco.Core.Configuration;
using Umbraco.Core.Logging;
using Umbraco.Core.Migrations.Install;
using Umbraco.Core.Persistence;
@@ -51,8 +52,8 @@ namespace Umbraco.Tests.Benchmarks
{
var logger = new DebugDiagnosticsLogger(new MessageTemplates());
var path = TestHelper.CurrentAssemblyDirectory;
-
- SetupSqlCe(path, logger);
+ var umbracoVersion = TestHelper.GetUmbracoVersion();
+ SetupSqlCe(path, logger, umbracoVersion);
SetupSqlServer(logger);
@@ -83,7 +84,7 @@ namespace Umbraco.Tests.Benchmarks
)");
}
- private void SetupSqlCe(string path, ILogger logger)
+ private void SetupSqlCe(string path, ILogger logger, IUmbracoVersion umbracoVersion)
{
var dbName = string.Concat("Umb", Guid.NewGuid(), ".sdf");
AppDomain.CurrentDomain.SetData("DataDirectory", path);
@@ -102,7 +103,7 @@ namespace Umbraco.Tests.Benchmarks
//use the db to create the initial schema so we can reuse in each bench
using (_dbSqlCe = GetSqlCeDatabase(sqlCeConnectionString, logger))
{
- var creation = new DatabaseSchemaCreator(_dbSqlCe, logger);
+ var creation = new DatabaseSchemaCreator(_dbSqlCe, logger, umbracoVersion);
creation.InitializeDatabaseSchema();
}
_initDbBytes = File.ReadAllBytes(_dbFile);
diff --git a/src/Umbraco.Tests/Configurations/GlobalSettingsTests.cs b/src/Umbraco.Tests/Configurations/GlobalSettingsTests.cs
index b7d67ed2cd..fba922b2c4 100644
--- a/src/Umbraco.Tests/Configurations/GlobalSettingsTests.cs
+++ b/src/Umbraco.Tests/Configurations/GlobalSettingsTests.cs
@@ -24,13 +24,6 @@ namespace Umbraco.Tests.Configurations
Current.IOHelper.Root = _root;
}
- [Ignore("fixme - ignored test")]
- [Test]
- public void Is_Version_From_Assembly_Correct()
- {
- Assert.That(Current.UmbracoVersion.SemanticVersion, Is.EqualTo("6.0.0"));
- }
-
[TestCase("~/umbraco", "/", "umbraco")]
[TestCase("~/umbraco", "/MyVirtualDir", "umbraco")]
[TestCase("~/customPath", "/MyVirtualDir/", "custompath")]
diff --git a/src/Umbraco.Tests/Migrations/AdvancedMigrationTests.cs b/src/Umbraco.Tests/Migrations/AdvancedMigrationTests.cs
index 01c93a40ec..82ccd21b80 100644
--- a/src/Umbraco.Tests/Migrations/AdvancedMigrationTests.cs
+++ b/src/Umbraco.Tests/Migrations/AdvancedMigrationTests.cs
@@ -42,7 +42,7 @@ namespace Umbraco.Tests.Migrations
upgrader.Execute(ScopeProvider, builder, Mock.Of(), logger);
- var helper = new DatabaseSchemaCreator(scope.Database, logger);
+ var helper = new DatabaseSchemaCreator(scope.Database, logger, UmbracoVersion);
var exists = helper.TableExists("umbracoUser");
Assert.IsTrue(exists);
diff --git a/src/Umbraco.Tests/Migrations/MigrationPlanTests.cs b/src/Umbraco.Tests/Migrations/MigrationPlanTests.cs
index ab065eb0a9..3241f78b62 100644
--- a/src/Umbraco.Tests/Migrations/MigrationPlanTests.cs
+++ b/src/Umbraco.Tests/Migrations/MigrationPlanTests.cs
@@ -12,6 +12,7 @@ using Umbraco.Core.Persistence;
using Umbraco.Core.Persistence.SqlSyntax;
using Umbraco.Core.Scoping;
using Umbraco.Core.Services;
+using Umbraco.Tests.TestHelpers;
using Umbraco.Tests.Testing;
namespace Umbraco.Tests.Migrations
@@ -137,7 +138,7 @@ namespace Umbraco.Tests.Migrations
[Test]
public void ValidateUmbracoPlan()
{
- var plan = new UmbracoPlan();
+ var plan = new UmbracoPlan(TestHelper.GetUmbracoVersion());
plan.Validate();
Console.WriteLine(plan.FinalState);
Assert.IsFalse(plan.FinalState.IsNullOrWhiteSpace());
diff --git a/src/Umbraco.Tests/Persistence/DatabaseContextTests.cs b/src/Umbraco.Tests/Persistence/DatabaseContextTests.cs
index 7ab9d2e28a..120ec6bc72 100644
--- a/src/Umbraco.Tests/Persistence/DatabaseContextTests.cs
+++ b/src/Umbraco.Tests/Persistence/DatabaseContextTests.cs
@@ -7,6 +7,7 @@ using Moq;
using NPoco;
using NUnit.Framework;
using Umbraco.Core;
+using Umbraco.Core.Configuration;
using Umbraco.Core.Logging;
using Umbraco.Core.Migrations.Install;
using Umbraco.Core.Persistence;
@@ -26,6 +27,7 @@ namespace Umbraco.Tests.Persistence
private ILogger _logger;
private SqlCeSyntaxProvider _sqlCeSyntaxProvider;
private ISqlSyntaxProvider[] _sqlSyntaxProviders;
+ private IUmbracoVersion _umbracoVersion;
[SetUp]
public void Setup()
@@ -34,6 +36,7 @@ namespace Umbraco.Tests.Persistence
_sqlCeSyntaxProvider = new SqlCeSyntaxProvider();
_sqlSyntaxProviders = new[] { (ISqlSyntaxProvider) _sqlCeSyntaxProvider };
_logger = Mock.Of();
+ _umbracoVersion = TestHelper.GetUmbracoVersion();
_databaseFactory = new UmbracoDatabaseFactory(_logger, new Lazy(() => Mock.Of()), TestHelper.GetConfigs());
}
@@ -88,7 +91,7 @@ namespace Umbraco.Tests.Persistence
using (var database = _databaseFactory.CreateDatabase())
using (var transaction = database.GetTransaction())
{
- schemaHelper = new DatabaseSchemaCreator(database, _logger);
+ schemaHelper = new DatabaseSchemaCreator(database, _logger, _umbracoVersion);
schemaHelper.InitializeDatabaseSchema();
transaction.Complete();
}
diff --git a/src/Umbraco.Tests/Persistence/SchemaValidationTest.cs b/src/Umbraco.Tests/Persistence/SchemaValidationTest.cs
index c7118dac79..99254edd77 100644
--- a/src/Umbraco.Tests/Persistence/SchemaValidationTest.cs
+++ b/src/Umbraco.Tests/Persistence/SchemaValidationTest.cs
@@ -22,7 +22,7 @@ namespace Umbraco.Tests.Persistence
using (var scope = ScopeProvider.CreateScope())
{
- var schema = new DatabaseSchemaCreator(scope.Database, Logger);
+ var schema = new DatabaseSchemaCreator(scope.Database, Logger, UmbracoVersion);
result = schema.ValidateSchema(
//TODO: When we remove the xml cache from tests we can remove this too
DatabaseSchemaCreator.OrderedTables.Concat(new []{typeof(ContentXmlDto), typeof(PreviewXmlDto)}));
diff --git a/src/Umbraco.Tests/Persistence/SqlCeTableByTableTest.cs b/src/Umbraco.Tests/Persistence/SqlCeTableByTableTest.cs
index 2afbdaca8f..660783c784 100644
--- a/src/Umbraco.Tests/Persistence/SqlCeTableByTableTest.cs
+++ b/src/Umbraco.Tests/Persistence/SqlCeTableByTableTest.cs
@@ -1,6 +1,7 @@
using Moq;
using NPoco;
using NUnit.Framework;
+using Umbraco.Core.Configuration;
using Umbraco.Core.Logging;
using Umbraco.Core.Migrations.Install;
using Umbraco.Core.Persistence;
@@ -20,7 +21,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
@@ -33,7 +34,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -47,7 +48,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -62,7 +63,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -76,7 +77,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -91,7 +92,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -105,7 +106,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -121,7 +122,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -137,7 +138,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -151,7 +152,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
@@ -164,7 +165,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -179,7 +180,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -193,7 +194,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -210,7 +211,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -226,7 +227,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -240,7 +241,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
@@ -253,7 +254,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
@@ -266,7 +267,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
@@ -279,7 +280,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -295,7 +296,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -312,7 +313,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -327,7 +328,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -344,7 +345,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -362,7 +363,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -379,7 +380,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -394,7 +395,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -409,20 +410,20 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
scope.Complete();
}
}
-
+
[Test]
public void Can_Create_cmsTags_Table()
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
@@ -435,7 +436,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -456,7 +457,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
@@ -469,7 +470,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -483,7 +484,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -497,7 +498,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
@@ -512,7 +513,7 @@ namespace Umbraco.Tests.Persistence
{
using (var scope = ScopeProvider.CreateScope())
{
- var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of());
+ var helper = new DatabaseSchemaCreator(scope.Database, Mock.Of(), UmbracoVersion);
helper.CreateTable();
helper.CreateTable();
diff --git a/src/Umbraco.Tests/Runtimes/StandaloneTests.cs b/src/Umbraco.Tests/Runtimes/StandaloneTests.cs
index 119211225a..d11438d4f4 100644
--- a/src/Umbraco.Tests/Runtimes/StandaloneTests.cs
+++ b/src/Umbraco.Tests/Runtimes/StandaloneTests.cs
@@ -153,7 +153,7 @@ namespace Umbraco.Tests.Runtimes
var scopeProvider = factory.GetInstance();
using (var scope = scopeProvider.CreateScope())
{
- var creator = new DatabaseSchemaCreator(scope.Database, logger);
+ var creator = new DatabaseSchemaCreator(scope.Database, logger, umbracoVersion);
creator.InitializeDatabaseSchema();
scope.Complete();
}
diff --git a/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs b/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs
index ee1a293f10..72f99dbdab 100644
--- a/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs
+++ b/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs
@@ -131,7 +131,7 @@ namespace Umbraco.Tests.TestHelpers
// ensure the configuration matches the current version for tests
var globalSettingsMock = Mock.Get(Factory.GetInstance()); //this will modify the IGlobalSettings instance stored in the container
- globalSettingsMock.Setup(x => x.ConfigurationStatus).Returns(Current.UmbracoVersion.Current.ToString(3));
+ globalSettingsMock.Setup(x => x.ConfigurationStatus).Returns(UmbracoVersion.Current.ToString(3));
using (ProfilingLogger.TraceDuration("Initialize database."))
{
@@ -303,7 +303,7 @@ namespace Umbraco.Tests.TestHelpers
{
using (var scope = ScopeProvider.CreateScope())
{
- var schemaHelper = new DatabaseSchemaCreator(scope.Database, Logger);
+ var schemaHelper = new DatabaseSchemaCreator(scope.Database, Logger, UmbracoVersion);
//Create the umbraco database and its base data
schemaHelper.InitializeDatabaseSchema();
diff --git a/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml b/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml
index 2eca580097..f59e70e174 100644
--- a/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml
+++ b/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml
@@ -57,7 +57,7 @@
redirectUrl = Url.Action("AuthorizeUpgrade", "BackOffice")
});
}
- @Html.BareMinimumServerVariablesScript(Url, externalLoginUrl, Model.Features, Model.GlobalSettings)
+ @Html.BareMinimumServerVariablesScript(Url, externalLoginUrl, Model.Features, Model.GlobalSettings, Model.UmbracoVersion)