Merge remote-tracking branch 'origin/v10/dev' into v10/feature/nullable-reference-types-in-Umbraco-Core
# Conflicts: # build/build.ps1 # src/Umbraco.Core/Configuration/ConfigConnectionString.cs # src/Umbraco.Core/Configuration/Models/ConnectionStrings.cs # src/Umbraco.Core/Install/InstallSteps/TelemetryIdentifierStep.cs # src/Umbraco.Core/Models/ContentType.cs # src/Umbraco.Infrastructure/Migrations/Install/DatabaseBuilder.cs # tests/Umbraco.Tests.AcceptanceTest/package.json
This commit is contained in:
@@ -1,10 +1,13 @@
|
||||
using System;
|
||||
using System.Threading.Tasks;
|
||||
using Microsoft.Extensions.DependencyInjection;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Microsoft.Extensions.Options;
|
||||
using Umbraco.Cms.Core.Configuration;
|
||||
using Umbraco.Cms.Core.Configuration.Models;
|
||||
using Umbraco.Cms.Core.Install.Models;
|
||||
using Umbraco.Cms.Core.Telemetry;
|
||||
using Umbraco.Cms.Web.Common.DependencyInjection;
|
||||
|
||||
namespace Umbraco.Cms.Core.Install.InstallSteps
|
||||
{
|
||||
@@ -13,32 +16,30 @@ namespace Umbraco.Cms.Core.Install.InstallSteps
|
||||
PerformsAppRestart = false)]
|
||||
public class TelemetryIdentifierStep : InstallSetupStep<object>
|
||||
{
|
||||
private readonly ILogger<TelemetryIdentifierStep> _logger;
|
||||
private readonly IOptions<GlobalSettings> _globalSettings;
|
||||
private readonly IConfigManipulator _configManipulator;
|
||||
private readonly ISiteIdentifierService _siteIdentifierService;
|
||||
|
||||
public TelemetryIdentifierStep(ILogger<TelemetryIdentifierStep> logger, IOptions<GlobalSettings> globalSettings, IConfigManipulator configManipulator)
|
||||
public TelemetryIdentifierStep(
|
||||
IOptions<GlobalSettings> globalSettings,
|
||||
ISiteIdentifierService siteIdentifierService)
|
||||
{
|
||||
_logger = logger;
|
||||
_globalSettings = globalSettings;
|
||||
_configManipulator = configManipulator;
|
||||
_siteIdentifierService = siteIdentifierService;
|
||||
}
|
||||
|
||||
[Obsolete("Use constructor that takes GlobalSettings and ISiteIdentifierService")]
|
||||
public TelemetryIdentifierStep(
|
||||
ILogger<TelemetryIdentifierStep> logger,
|
||||
IOptions<GlobalSettings> globalSettings,
|
||||
IConfigManipulator configManipulator)
|
||||
: this(globalSettings, StaticServiceProvider.Instance.GetRequiredService<ISiteIdentifierService>())
|
||||
{
|
||||
}
|
||||
|
||||
public override Task<InstallSetupResult?> ExecuteAsync(object model)
|
||||
{
|
||||
// Generate GUID
|
||||
var telemetrySiteIdentifier = Guid.NewGuid();
|
||||
|
||||
try
|
||||
{
|
||||
_configManipulator.SetGlobalId(telemetrySiteIdentifier.ToString());
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Couldn't update config files with a telemetry site identifier");
|
||||
}
|
||||
|
||||
return Task.FromResult<InstallSetupResult?>(null);
|
||||
_siteIdentifierService.TryCreateSiteIdentifier(out _);
|
||||
return Task.FromResult<InstallSetupResult>(null);
|
||||
}
|
||||
|
||||
public override bool RequiresExecution(object model)
|
||||
|
||||
Reference in New Issue
Block a user