From 53bc92608ac647b468b0108bcb85443a067effd0 Mon Sep 17 00:00:00 2001 From: Shannon Date: Fri, 8 Jan 2021 00:33:47 +1100 Subject: [PATCH] rename property --- src/Umbraco.Core/Routing/IPublishedRequest.cs | 5 ++++- src/Umbraco.Core/Routing/PublishedRequest.cs | 4 ++-- .../Umbraco.Core/Web/Routing/PublishedRequestBuilderTests.cs | 2 +- .../Controllers/PublishedRequestFilterAttribute.cs | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/Umbraco.Core/Routing/IPublishedRequest.cs b/src/Umbraco.Core/Routing/IPublishedRequest.cs index 8bfb49d9ac..3d6ab51276 100644 --- a/src/Umbraco.Core/Routing/IPublishedRequest.cs +++ b/src/Umbraco.Core/Routing/IPublishedRequest.cs @@ -72,6 +72,9 @@ namespace Umbraco.Web.Routing /// IReadOnlyDictionary Headers { get; } - bool CacheabilityNoCache { get; } + /// + /// Gets a value indicating if the no-cache value should be added to the Cache-Control header + /// + bool SetNoCacheHeader { get; } } } diff --git a/src/Umbraco.Core/Routing/PublishedRequest.cs b/src/Umbraco.Core/Routing/PublishedRequest.cs index bc8450177e..7f1f8b63b5 100644 --- a/src/Umbraco.Core/Routing/PublishedRequest.cs +++ b/src/Umbraco.Core/Routing/PublishedRequest.cs @@ -27,7 +27,7 @@ namespace Umbraco.Web.Routing ResponseStatusCode = responseStatusCode; CacheExtensions = cacheExtensions; Headers = headers; - CacheabilityNoCache = cacheabilityNoCache; + SetNoCacheHeader = cacheabilityNoCache; } /// @@ -64,6 +64,6 @@ namespace Umbraco.Web.Routing public IReadOnlyDictionary Headers { get; } /// - public bool CacheabilityNoCache { get; } + public bool SetNoCacheHeader { get; } } } diff --git a/src/Umbraco.Tests.UnitTests/Umbraco.Core/Web/Routing/PublishedRequestBuilderTests.cs b/src/Umbraco.Tests.UnitTests/Umbraco.Core/Web/Routing/PublishedRequestBuilderTests.cs index 80e39f82ba..cf4ca44f10 100644 --- a/src/Umbraco.Tests.UnitTests/Umbraco.Core/Web/Routing/PublishedRequestBuilderTests.cs +++ b/src/Umbraco.Tests.UnitTests/Umbraco.Core/Web/Routing/PublishedRequestBuilderTests.cs @@ -81,7 +81,7 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Core.Web.Routing IPublishedRequest request = sut.Build(); - Assert.AreEqual(true, request.CacheabilityNoCache); + Assert.AreEqual(true, request.SetNoCacheHeader); Assert.AreEqual(cacheExt, request.CacheExtensions); Assert.AreEqual(usCulture, request.Culture); Assert.AreEqual(domain, request.Domain); diff --git a/src/Umbraco.Web.Common/Controllers/PublishedRequestFilterAttribute.cs b/src/Umbraco.Web.Common/Controllers/PublishedRequestFilterAttribute.cs index 61e21df4cb..a33dba9ca6 100644 --- a/src/Umbraco.Web.Common/Controllers/PublishedRequestFilterAttribute.cs +++ b/src/Umbraco.Web.Common/Controllers/PublishedRequestFilterAttribute.cs @@ -55,7 +55,7 @@ namespace Umbraco.Web.Common.Controllers { var cacheControlHeaders = new List(); - if (pcr.CacheabilityNoCache) + if (pcr.SetNoCacheHeader) { cacheControlHeaders.Add("no-cache"); }