yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: assume the value isn't set by default (some migrations may have deleted it)

Browse Source 
Approved-By: leekelleher <leekelleher@gmail.com>
This commit is contained in:
Jacob Overgaard
2024-03-14 09:42:03 +01:00
parent 8d81431d10
commit 544aafc8ed
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/column-configuration/property-editor-ui-collection-view-column-configuration.element.ts
View File

@@ -16,7 +16,7 @@ export class UmbPropertyEditorUICollectionViewColumnConfigurationElement
implements UmbPropertyEditorUiElement implements UmbPropertyEditorUiElement
{ {
@property({ type: Array }) @property({ type: Array })
value: Array<UmbCollectionColumnConfiguration> = []; value?: Array<UmbCollectionColumnConfiguration> = [];
@property({ type: Object, attribute: false }) @property({ type: Object, attribute: false })
public config?: UmbPropertyEditorConfigCollection; public config?: UmbPropertyEditorConfigCollection;
@@ -31,7 +31,7 @@ export class UmbPropertyEditorUICollectionViewColumnConfigurationElement
this._field = element.selectedProperty; this._field = element.selectedProperty;
const duplicate = this.value.find((config) => this._field?.alias === config.alias); const duplicate = this.value?.find((config) => this._field?.alias === config.alias);
if (duplicate) { if (duplicate) {
// TODO: Show error to user, can not add duplicate field/column. [LK] // TODO: Show error to user, can not add duplicate field/column. [LK]
@@ -44,7 +44,7 @@ export class UmbPropertyEditorUICollectionViewColumnConfigurationElement
isSystem: this._field.isSystem ? 1 : 0, isSystem: this._field.isSystem ? 1 : 0,
}; };
this.value = [...this.value, config]; this.value = [...(this.value ?? []), config];
this.dispatchEvent(new UmbPropertyValueChangeEvent()); this.dispatchEvent(new UmbPropertyValueChangeEvent());
} }
@@ -52,7 +52,7 @@ export class UmbPropertyEditorUICollectionViewColumnConfigurationElement
#onRemove(unique: string) { #onRemove(unique: string) {
const newValue: Array<UmbCollectionColumnConfiguration> = []; const newValue: Array<UmbCollectionColumnConfiguration> = [];
this.value.forEach((config) => { this.value?.forEach((config) => {
if (config.alias !== unique) newValue.push(config); if (config.alias !== unique) newValue.push(config);
}); });
@@ -61,7 +61,7 @@ export class UmbPropertyEditorUICollectionViewColumnConfigurationElement
} }
#onHeaderChange(e: UUIInputEvent, configuration: UmbCollectionColumnConfiguration) { #onHeaderChange(e: UUIInputEvent, configuration: UmbCollectionColumnConfiguration) {
this.value = this.value.map( this.value = this.value?.map(
(config): UmbCollectionColumnConfiguration => (config): UmbCollectionColumnConfiguration =>
config.alias === configuration.alias ? { ...config, header: e.target.value as string } : config, config.alias === configuration.alias ? { ...config, header: e.target.value as string } : config,
); );
@@ -70,7 +70,7 @@ export class UmbPropertyEditorUICollectionViewColumnConfigurationElement
} }
#onTemplateChange(e: UUIInputEvent, configuration: UmbCollectionColumnConfiguration) { #onTemplateChange(e: UUIInputEvent, configuration: UmbCollectionColumnConfiguration) {
this.value = this.value.map( this.value = this.value?.map(
(config): UmbCollectionColumnConfiguration => (config): UmbCollectionColumnConfiguration =>
config.alias === configuration.alias ? { ...config, nameTemplate: e.target.value as string } : config, config.alias === configuration.alias ? { ...config, nameTemplate: e.target.value as string } : config,
); );