diff --git a/src/Umbraco.Core/Services/NotificationService.cs b/src/Umbraco.Core/Services/NotificationService.cs index 24dbb0089a..3d5673fd7a 100644 --- a/src/Umbraco.Core/Services/NotificationService.cs +++ b/src/Umbraco.Core/Services/NotificationService.cs @@ -374,47 +374,7 @@ public class NotificationService : INotificationService // build summary var summary = new StringBuilder(); - if (content.ContentType.VariesByNothing()) - { - if (!_contentSettings.Notifications.DisableHtmlEmail) - { - // create the HTML summary for invariant content - - // list all of the property values like we used to - summary.Append(""); - foreach (IProperty p in content.Properties) - { - // TODO: doesn't take into account variants - var newText = p.GetValue() != null ? p.GetValue()?.ToString() : string.Empty; - var oldText = newText; - - // check if something was changed and display the changes otherwise display the fields - if (oldDoc?.Properties.Contains(p.PropertyType.Alias) ?? false) - { - IProperty? oldProperty = oldDoc.Properties[p.PropertyType.Alias]; - oldText = oldProperty?.GetValue() != null ? oldProperty.GetValue()?.ToString() : string.Empty; - - // replace HTML with char equivalent - ReplaceHtmlSymbols(ref oldText); - ReplaceHtmlSymbols(ref newText); - } - - // show the values - summary.Append(""); - summary.Append( - ""); - summary.Append(""); - summary.Append(""); - } - - summary.Append("
"); - summary.Append(p.PropertyType.Name); - summary.Append(""); - summary.Append(newText); - summary.Append("
"); - } - } - else if (content.ContentType.VariesByCulture()) + if (content.ContentType.VariesByCulture()) { // it's variant, so detect what cultures have changed if (!_contentSettings.Notifications.DisableHtmlEmail) @@ -454,8 +414,43 @@ public class NotificationService : INotificationService } else { - // not supported yet... - throw new NotSupportedException(); + if (!_contentSettings.Notifications.DisableHtmlEmail) + { + // create the HTML summary for invariant content + + // list all of the property values like we used to + summary.Append(""); + foreach (IProperty p in content.Properties) + { + // TODO: doesn't take into account variants + var newText = p.GetValue() != null ? p.GetValue()?.ToString() : string.Empty; + var oldText = newText; + + // check if something was changed and display the changes otherwise display the fields + if (oldDoc?.Properties.Contains(p.PropertyType.Alias) ?? false) + { + IProperty? oldProperty = oldDoc.Properties[p.PropertyType.Alias]; + oldText = oldProperty?.GetValue() != null ? oldProperty.GetValue()?.ToString() : string.Empty; + + // replace HTML with char equivalent + ReplaceHtmlSymbols(ref oldText); + ReplaceHtmlSymbols(ref newText); + } + + // show the values + summary.Append(""); + summary.Append( + ""); + summary.Append(""); + summary.Append(""); + } + + summary.Append("
"); + summary.Append(p.PropertyType.Name); + summary.Append(""); + summary.Append(newText); + summary.Append("
"); + } } var protocol = _globalSettings.UseHttps ? "https" : "http";