yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove await Task.FromResult() and unnecessary async modifiers (#16535)

Browse Source 
* Remove await Task.FromResult and unnecessary async modifiers

* Remove usage of await Task.WhenAll() to avoid deadlocks

* Fix code formatting

---------

Co-authored-by: Andy Butland <abutland73@gmail.com>
This commit is contained in:
Ronald Barendse
2025-03-03 06:47:37 +01:00
committed by GitHub
parent 064a71240e
commit 561d871677
126 changed files with 600 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberManagerTests.cs
View File

@@ -113,7 +113,7 @@ public class MemberManagerTests
}
[Test]
public async Task GivenICreateUser_AndTheUserIsNull_ThenIShouldGetAFailedResultAsync()
public Task GivenICreateUser_AndTheUserIsNull_ThenIShouldGetAFailedResultAsync()
{
// arrange
var sut = CreateSut();
@@ -124,6 +124,7 @@ public class MemberManagerTests
// act
Assert.ThrowsAsync<ArgumentNullException>(async () => await sut.CreateAsync(null));
return Task.CompletedTask;
}
[Test]

6
tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberRoleStoreTests.cs
View File

@@ -201,7 +201,7 @@ public class MemberRoleStoreTests
}
[Test]
public async Task
public Task
GivenIDeleteAMemberRole_AndTheIdCannotBeParsedToAnInt_ThenTheMemberGroupShouldNotBeDeleted_AndIShouldGetAnArgumentException()
{
// arrange
@@ -214,6 +214,7 @@ public class MemberRoleStoreTests
// act
Assert.ThrowsAsync<ArgumentException>(async () => await sut.DeleteAsync(fakeRole, fakeCancellationToken));
return Task.CompletedTask;
}
[Test]
@@ -263,7 +264,7 @@ public class MemberRoleStoreTests
}
[Test]
public async Task GivenIFindAMemberRoleByRoleId_AndIdCannotBeParsedToAnIntOrGuid_ThenIShouldGetAFailureResultAsync()
public Task GivenIFindAMemberRoleByRoleId_AndIdCannotBeParsedToAnIntOrGuid_ThenIShouldGetAFailureResultAsync()
{
// arrange
var sut = CreateSut();
@@ -276,6 +277,7 @@ public class MemberRoleStoreTests
// assert
Assert.That(actual, Throws.TypeOf<ArgumentOutOfRangeException>());
_mockMemberGroupService.VerifyNoOtherCalls();
return Task.CompletedTask;
}
[Test]