From 562f4c7d4c9cf6cdc96d4513a7fde9665dc07213 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Wed, 31 May 2023 20:12:40 +0200 Subject: [PATCH] Use connectedCallback --- .../allowed-document-types-modal.element.ts | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/modals/allowed-document-types/allowed-document-types-modal.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/modals/allowed-document-types/allowed-document-types-modal.element.ts index 27007bc7dd..b5dd91b23b 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/modals/allowed-document-types/allowed-document-types-modal.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/modals/allowed-document-types/allowed-document-types-modal.element.ts @@ -1,5 +1,5 @@ import { UmbDocumentTypeRepository } from '../../repository/document-type.repository.js'; -import { html, nothing , customElement, state , ifDefined } from '@umbraco-cms/backoffice/external/lit'; +import { html, nothing, customElement, state, ifDefined } from '@umbraco-cms/backoffice/external/lit'; import { UUITextStyles } from '@umbraco-cms/backoffice/external/uui'; import { UmbAllowedDocumentTypesModalData, UmbAllowedDocumentTypesModalResult } from '@umbraco-cms/backoffice/modal'; import { UmbModalBaseElement } from '@umbraco-cms/internal/modal'; @@ -15,12 +15,17 @@ export class UmbAllowedDocumentTypesModalElement extends UmbModalBaseElement< @state() private _allowedDocumentTypes: DocumentTypeTreeItemResponseModel[] = []; - async firstUpdated() { + public connectedCallback() { + super.connectedCallback(); // TODO: Support root aka. id of null? or maybe its an active prop, like 'atRoot'. // TODO: show error - if (!this.data?.id) return; + if (this.data?.id) { + this._retrieveAllowedChildrenOf(this.data.id); + } + } - const { data } = await this.#documentTypeRepository.requestAllowedChildTypesOf(this.data.id); + private async _retrieveAllowedChildrenOf(id: string) { + const { data } = await this.#documentTypeRepository.requestAllowedChildTypesOf(id); if (data) { this._allowedDocumentTypes = data; @@ -41,7 +46,7 @@ export class UmbAllowedDocumentTypesModalElement extends UmbModalBaseElement< render() { return html` - + ${this._allowedDocumentTypes.length === 0 ? html`

No allowed types

` : nothing} ${this._allowedDocumentTypes.map(