yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean up section alias condition

Browse Source
This commit is contained in:
Niels Lyngsø
2023-07-28 11:28:18 +02:00
parent 608c9a84e6
commit 56321e469f
2 changed files with 71 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/conditions/section-alias.condition.tempts Normal file
View File

@@ -0,0 +1,60 @@
import { UmbBaseController, UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import {
ManifestCondition,
UmbConditionConfigBase,
UmbExtensionCondition,
} from '@umbraco-cms/backoffice/extension-api';
import { UMB_SECTION_CONTEXT_TOKEN } from '@umbraco-cms/backoffice/section';
export class UmbSectionAliasCondition extends UmbBaseController implements UmbExtensionCondition {
config: SectionAliasConditionConfig;
permitted = false;
#onChange: () => void;
constructor(args: { host: UmbControllerHost; config: SectionAliasConditionConfig; onChange: () => void }) {
super(args.host);
this.config = args.config;
this.#onChange = args.onChange;
this.consumeContext(UMB_SECTION_CONTEXT_TOKEN, (context) => {
//if (context) {
this.observe(
context.alias,
(sectionAlias) => {
// TODO: Would be nice to make the object fully controllable by each condition, but requires some typing system.
this.permitted = sectionAlias === this.config.match;
this.#onChange();
}
//,
//'_observeSectionAlias'
);
//}
// Niels: As is of this state, contexts cannot be unprovided, so this code is not needed:
/*else {
this.removeControllerByAlias('_observeSectionAlias');
if (this.permitted === true) {
this.permitted = false;
this.#onChange();
}
}*/
});
}
/*
hostDisconnected() {
super.hostDisconnected();
this.permitted = false;
this.#onChange();
}
*/
}
export const manifest: ManifestCondition = {
type: 'condition',
name: 'Section Alias Condition',
alias: 'Umb.Condition.SectionAlias',
class: UmbSectionAliasCondition,
};
export type SectionAliasConditionConfig = UmbConditionConfigBase & {
match: string;
};

45
src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/conditions/section-alias.condition.ts
View File

@@ -1,51 +1,32 @@
import { UmbBaseController, UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { UmbBaseController } from '@umbraco-cms/backoffice/controller-api';
import {
ManifestCondition,
UmbConditionConfigBase,
UmbConditionControllerArguments,
UmbExtensionCondition,
} from '@umbraco-cms/backoffice/extension-api';
import { UMB_SECTION_CONTEXT_TOKEN } from '@umbraco-cms/backoffice/section';
export type SectionAliasConditionConfig = UmbConditionConfigBase & {
match: string;
};
export class UmbSectionAliasCondition extends UmbBaseController implements UmbExtensionCondition {
config: SectionAliasConditionConfig;
permitted = false;
#onChange: () => void;
constructor(args: { host: UmbControllerHost; config: SectionAliasConditionConfig; onChange: () => void }) {
constructor(args: UmbConditionControllerArguments<SectionAliasConditionConfig>) {
super(args.host);
this.config = args.config;
this.#onChange = args.onChange;
this.consumeContext(UMB_SECTION_CONTEXT_TOKEN, (context) => {
//if (context) {
this.observe(
context.alias,
(sectionAlias) => {
// TODO: Would be nice to make the object fully controllable by each condition, but requires some typing system.
this.permitted = sectionAlias === this.config.match;
this.#onChange();
}
//,
//'_observeSectionAlias'
);
//}
// Niels: As is of this state, contexts cannot be unprovided, so this code is not needed:
/*else {
this.removeControllerByAlias('_observeSectionAlias');
if (this.permitted === true) {
this.permitted = false;
this.#onChange();
}
}*/
this.observe(context.alias, (sectionAlias) => {
this.permitted = sectionAlias === this.config.match;
this.#onChange();
});
});
}
/*
hostDisconnected() {
super.hostDisconnected();
this.permitted = false;
this.#onChange();
}
*/
}
export const manifest: ManifestCondition = {
@@ -54,7 +35,3 @@ export const manifest: ManifestCondition = {
alias: 'Umb.Condition.SectionAlias',
class: UmbSectionAliasCondition,
};
export type SectionAliasConditionConfig = UmbConditionConfigBase & {
match: string;
};