From e46687892528b13d01747cd1b2fc5abc7be31014 Mon Sep 17 00:00:00 2001 From: leekelleher Date: Thu, 18 Jan 2018 10:04:55 +0000 Subject: [PATCH] U4-10842 LegacyMediaPickerPropertyConverter ConvertDataToSource null-reference check If a selected media node has been trashed on the source environment, when Deploy comes to transfer the node ID, because it can't transfer the media dependency, the node ID value is set to `null`. This causes an issue for the `LegacyMediaPickerPropertyConverter` and `ConvertDataToSource` throws a null-reference exception. This patch adds in a null-reference check for the `source` value. --- .../ValueConverters/LegacyMediaPickerPropertyConverter.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Umbraco.Web/PropertyEditors/ValueConverters/LegacyMediaPickerPropertyConverter.cs b/src/Umbraco.Web/PropertyEditors/ValueConverters/LegacyMediaPickerPropertyConverter.cs index 8ef11bec8d..1f9291d629 100644 --- a/src/Umbraco.Web/PropertyEditors/ValueConverters/LegacyMediaPickerPropertyConverter.cs +++ b/src/Umbraco.Web/PropertyEditors/ValueConverters/LegacyMediaPickerPropertyConverter.cs @@ -85,6 +85,9 @@ namespace Umbraco.Web.PropertyEditors.ValueConverters /// public override object ConvertDataToSource(PublishedPropertyType propertyType, object source, bool preview) { + if (source == null) + return null; + if (IsMultipleDataType(propertyType.DataTypeId, propertyType.PropertyEditorAlias)) { var nodeIds =