Remove the crazy Func param on AddUmbracoCore

src/Umbraco.Web.Common/AspNetCore/AspNetCoreHostingEnvironmentWithoutOptionsMonitor.cs

@@ -0,0 +1,112 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Text;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.Extensions.Options;
+using Umbraco.Core;
+using Umbraco.Core.Configuration;
+using Umbraco.Core.Configuration.Models;
+
+namespace Umbraco.Web.Common.AspNetCore
+{
+    public class AspNetCoreHostingEnvironmentWithoutOptionsMonitor : Core.Hosting.IHostingEnvironment
+    {
+
+        private HostingSettings _hostingSettings;
+        private readonly IWebHostEnvironment _webHostEnvironment;
+
+        private string _localTempPath;
+
+        public AspNetCoreHostingEnvironmentWithoutOptionsMonitor(HostingSettings hostingSettings, IWebHostEnvironment webHostEnvironment)
+        {
+            _hostingSettings = hostingSettings ?? throw new ArgumentNullException(nameof(hostingSettings));
+            _webHostEnvironment = webHostEnvironment ?? throw new ArgumentNullException(nameof(webHostEnvironment));
+
+            SiteName = webHostEnvironment.ApplicationName;
+            ApplicationId = AppDomain.CurrentDomain.Id.ToString();
+            ApplicationPhysicalPath = webHostEnvironment.ContentRootPath;
+
+            IISVersion = new Version(0, 0); // TODO not necessary IIS
+        }
+
+
+        public bool IsHosted { get; } = true;
+        public string SiteName { get; }
+        public string ApplicationId { get; }
+        public string ApplicationPhysicalPath { get; }
+        public string ApplicationServerAddress { get; }
+
+        //TODO how to find this, This is a server thing, not application thing.
+        public string ApplicationVirtualPath => _hostingSettings.ApplicationVirtualPath?.EnsureStartsWith('/') ?? "/";
+        public bool IsDebugMode => _hostingSettings.Debug;
+
+        public Version IISVersion { get; }
+        public string LocalTempPath
+        {
+            get
+            {
+                if (_localTempPath != null)
+                    return _localTempPath;
+
+                switch (_hostingSettings.LocalTempStorageLocation)
+                {
+                    case LocalTempStorage.AspNetTemp:
+
+                        // TODO: I don't think this is correct? but also we probably can remove AspNetTemp as an option entirely
+                        // since this is legacy and we shouldn't use it
+                        return _localTempPath = System.IO.Path.Combine(Path.GetTempPath(), ApplicationId, "UmbracoData");
+
+                    case LocalTempStorage.EnvironmentTemp:
+
+                        // environment temp is unique, we need a folder per site
+
+                        // use a hash
+                        // combine site name and application id
+                        //  site name is a Guid on Cloud
+                        //  application id is eg /LM/W3SVC/123456/ROOT
+                        // the combination is unique on one server
+                        // and, if a site moves from worker A to B and then back to A...
+                        //  hopefully it gets a new Guid or new application id?
+
+                        var hashString = SiteName + "::" + ApplicationId;
+                        var hash = hashString.GenerateHash();
+                        var siteTemp = System.IO.Path.Combine(Environment.ExpandEnvironmentVariables("%temp%"), "UmbracoData", hash);
+
+                        return _localTempPath = siteTemp;
+
+                    //case LocalTempStorage.Default:
+                    //case LocalTempStorage.Unknown:
+                    default:
+                        return _localTempPath = MapPathContentRoot("~/App_Data/TEMP");
+                }
+            }
+        }
+
+        public string MapPathWebRoot(string path)
+        {
+            var newPath = path.TrimStart('~', '/').Replace('/', Path.DirectorySeparatorChar);
+            return Path.Combine(_webHostEnvironment.WebRootPath, newPath);
+        }
+
+        public string MapPathContentRoot(string path)
+        {
+            var newPath = path.TrimStart('~', '/').Replace('/', Path.DirectorySeparatorChar);
+            return Path.Combine(_webHostEnvironment.ContentRootPath, newPath);
+        }
+
+        public string ToAbsolute(string virtualPath)
+        {
+            if (!virtualPath.StartsWith("~/") && !virtualPath.StartsWith("/"))
+                throw new InvalidOperationException($"The value {virtualPath} for parameter {nameof(virtualPath)} must start with ~/ or /");
+
+            // will occur if it starts with "/"
+            if (Uri.IsWellFormedUriString(virtualPath, UriKind.Absolute))
+                return virtualPath;
+
+            var fullPath = ApplicationVirtualPath.EnsureEndsWith('/') + virtualPath.TrimStart("~/").TrimStart("/");
+
+            return fullPath;
+        }
+    }
+}