From 5d9cf8254e227efc7532d129eeab2ab13a44526d Mon Sep 17 00:00:00 2001 From: Shannon Date: Mon, 12 Apr 2021 18:23:53 +1000 Subject: [PATCH] removes tests that were just testing the framework --- .../Security/MemberUserStore.cs | 6 +- .../Security/MemberUserStoreTests.cs | 55 +------------------ 2 files changed, 7 insertions(+), 54 deletions(-) diff --git a/src/Umbraco.Infrastructure/Security/MemberUserStore.cs b/src/Umbraco.Infrastructure/Security/MemberUserStore.cs index 6e08040de3..53420ff667 100644 --- a/src/Umbraco.Infrastructure/Security/MemberUserStore.cs +++ b/src/Umbraco.Infrastructure/Security/MemberUserStore.cs @@ -50,10 +50,12 @@ namespace Umbraco.Cms.Core.Security public override IQueryable Users => throw new NotImplementedException(); /// - public override Task GetNormalizedUserNameAsync(MemberIdentityUser user, CancellationToken cancellationToken = default) => GetUserNameAsync(user, cancellationToken); + public override Task GetNormalizedUserNameAsync(MemberIdentityUser user, CancellationToken cancellationToken = default) + => GetUserNameAsync(user, cancellationToken); /// - public override Task SetNormalizedUserNameAsync(MemberIdentityUser user, string normalizedName, CancellationToken cancellationToken = default) => SetUserNameAsync(user, normalizedName, cancellationToken); + public override Task SetNormalizedUserNameAsync(MemberIdentityUser user, string normalizedName, CancellationToken cancellationToken = default) + => SetUserNameAsync(user, normalizedName, cancellationToken); /// public override Task CreateAsync(MemberIdentityUser user, CancellationToken cancellationToken = default) diff --git a/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberUserStoreTests.cs b/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberUserStoreTests.cs index 8391fa7f3c..49b572601e 100644 --- a/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberUserStoreTests.cs +++ b/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberUserStoreTests.cs @@ -39,56 +39,7 @@ namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Infrastructure.Security } [Test] - public void GivenIGetNormalizedUserName_AndTheUserIsNull_ThenIShouldGetAnException() - { - // arrange - MemberUserStore sut = CreateSut(); - - // act - Assert.ThrowsAsync(async () => await sut.GetNormalizedUserNameAsync(null, CancellationToken.None)); - } - - [Test] - public async Task GivenIGetNormalizedUserName_AndTheEverythingIsPopulatedCorrectly_ThenIShouldGetACorrectUsername() - { - // arrange - MemberUserStore sut = CreateSut(); - var fakeUser = new MemberIdentityUser() - { - UserName = "fakeuser" - }; - - // act - string actual = await sut.GetNormalizedUserNameAsync(fakeUser); - - // assert - Assert.AreEqual(actual, fakeUser.UserName); - } - - [Test] - public void GivenISetNormalizedUserName_AndTheUserIsNull_ThenIShouldGetAnException() - { - // arrange - MemberUserStore sut = CreateSut(); - - // act - Assert.ThrowsAsync(async () => await sut.SetNormalizedUserNameAsync(null, "username", CancellationToken.None)); - } - - - [Test] - public void GivenISetNormalizedUserName_AndTheUserNameIsNull_ThenAnExceptionShouldBeThrown() - { - // arrange - MemberUserStore sut = CreateSut(); - var fakeUser = new MemberIdentityUser(); - - // act - Assert.ThrowsAsync(async () => await sut.SetNormalizedUserNameAsync(fakeUser, null, CancellationToken.None)); - } - - [Test] - public async Task GivenISetNormalizedUserName_AndEverythingIsPopulated_ThenIShouldGetASuccessResult() + public async Task GivenISetNormalizedUserName_ThenIShouldGetASuccessResult() { // arrange MemberUserStore sut = CreateSut(); @@ -101,8 +52,8 @@ namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Infrastructure.Security await sut.SetNormalizedUserNameAsync(fakeUser, "NewName", CancellationToken.None); // assert - Assert.AreEqual("NewName", fakeUser.Name); - Assert.AreEqual("NewName", fakeUser.NormalizedUserName); + Assert.AreEqual("NewName", fakeUser.UserName); + Assert.AreEqual("NewName", await sut.GetNormalizedUserNameAsync(fakeUser, CancellationToken.None)); } [Test]