From 606b5aa60ad1cf8990853d64b8481e4539e7948f Mon Sep 17 00:00:00 2001 From: Shannon Date: Thu, 20 Feb 2014 13:55:56 +1100 Subject: [PATCH] fixes logic in membershiphelper updatemember --- src/Umbraco.Web/Security/MembershipHelper.cs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Umbraco.Web/Security/MembershipHelper.cs b/src/Umbraco.Web/Security/MembershipHelper.cs index 4695a74154..899661ead6 100644 --- a/src/Umbraco.Web/Security/MembershipHelper.cs +++ b/src/Umbraco.Web/Security/MembershipHelper.cs @@ -576,37 +576,37 @@ namespace Umbraco.Web.Security DateTime? lastActivityDate = null, string comment = null) { - var needsUpdating = false; + var needsUpdating = new List(); //set the writable properties if (email != null) { - needsUpdating = member.Email != email; + needsUpdating.Add(member.Email != email); member.Email = email; } if (isApproved.HasValue) { - needsUpdating = member.IsApproved != isApproved.Value; + needsUpdating.Add(member.IsApproved != isApproved.Value); member.IsApproved = isApproved.Value; } if (lastLoginDate.HasValue) { - needsUpdating = member.LastLoginDate != lastLoginDate.Value; + needsUpdating.Add(member.LastLoginDate != lastLoginDate.Value); member.LastLoginDate = lastLoginDate.Value; } if (lastActivityDate.HasValue) { - needsUpdating = member.LastActivityDate != lastActivityDate.Value; + needsUpdating.Add(member.LastActivityDate != lastActivityDate.Value); member.LastActivityDate = lastActivityDate.Value; } if (comment != null) { - needsUpdating = member.Comment != comment; + needsUpdating.Add(member.Comment != comment); member.Comment = comment; } //Don't persist anything if nothing has changed - if (needsUpdating) + if (needsUpdating.Any(x => x == true)) { provider.UpdateUser(member); return Attempt.Succeed(member);