yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V13: Add parentkey to notifications (#13832)

Browse Source 
* Add parent key to CopyingNotification

* Use parentkey on notifications

* Implement ParentKeys for Copying notification

* Obsolete parentId

* Implement MoveToEventInfoBase

* Refactor MovingToRecycleBinNotification to use the new MoveEVentInfoBase

* Refactor MediaMovingToRecycleBinNotification

* Refactor MovedToRecycleBinNotification to use new MoveEventInfo

* Refactor ContentMovedToRecycleBinNotification to use new MoveEventInfo

* Start implementing parent key in moveinfo

* Add FIXME's to move methods

* Refactor Move to get parentKey for descendants

* Add FIXME for move method

* Use MoveToRecycleBinEventInfo in RelateOnTrashNotificationHandler

* Add fixme's to DataTypeRepository

* Add obsolete messages

* Revert changes in ContentTypeServiceBaseOfTRepositoryTItemTService.cs

* Fix bad indentation

* Pass the recursive variable

* Revert changes in ContentService.cs

* Refactor MoveEventInfo to not duplicate equals method

* Refactor Equals to not duplicate code

* Add UnitTests of Equals

* make equals public and add non-happy path tests

* Remvoe duplicate call to base

---------

Co-authored-by: Zeegaan <nge@umbraco.dk>
This commit is contained in:
Nikolaj Geisle
2023-02-27 08:40:17 +01:00
committed by GitHub
parent c2ecc8dc33
commit 5e90fa26c1
21 changed files with 193 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Events/MoveEventInfoTests.cs Normal file
View File

@@ -0,0 +1,55 @@
using NUnit.Framework;
using Umbraco.Cms.Core.Events;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.Events;
public class MoveEventInfoTests
{
[TestCase("", "path", false)]
[TestCase("entity", "", false)]
[TestCase("entity", "path", true)]
public void Can_Equate_Move_To_Recyclebin_Move_Event_Infos(string entity, string originalPath, bool expectedResult)
{
var recycleBinMoveEvent = new MoveToRecycleBinEventInfo<string>(entity, originalPath);
var recycleBinMoveEventTwo = new MoveToRecycleBinEventInfo<string>("entity", "path");
Assert.AreEqual(expectedResult, recycleBinMoveEvent.Equals(recycleBinMoveEventTwo));
}
[Test]
public void Can_Equate_Move_To_Recyclebin_Move_Event_Infos_All_Params_Null_Or_Empty()
{
var recycleBinMoveEvent = new MoveToRecycleBinEventInfo<string>(string.Empty, string.Empty);
var recycleBinMoveEventTwo = new MoveToRecycleBinEventInfo<string>(string.Empty, string.Empty);
Assert.IsTrue(recycleBinMoveEvent.Equals(recycleBinMoveEventTwo));
}
[Test]
public void Can_Equate_Move_Event_Infos_Parent_Key_Null()
{
var moveEvent = new MoveEventInfo<string>("entity", "path", 123, null);
var moveEventTwo = new MoveEventInfo<string>("entity", "path", 123, null);
Assert.IsTrue(moveEvent.Equals(moveEventTwo));
}
[Test]
public void Can_Equate_Move_Event_Infos_All_Params_Null_Or_Empty()
{
var moveEvent = new MoveEventInfo<string>(string.Empty, string.Empty, 0, null);
var moveEventTwo = new MoveEventInfo<string>(string.Empty, string.Empty, 0, null);
Assert.IsTrue(moveEvent.Equals(moveEventTwo));
}
[TestCase(123, "entity", "", "063897F1-194A-4C42-B406-CA80DBC12968", false)]
[TestCase(123, "", "path", "063897F1-194A-4C42-B406-CA80DBC12968", false)]
[TestCase(12, "entity", "path", "063897F1-194A-4C42-B406-CA80DBC12968", false)]
[TestCase(123, "entity", "path", "C6D6EA3E-C2B0-483F-B772-2F4D8BBF5027", false)]
[TestCase(123, "entity", "path", "063897F1-194A-4C42-B406-CA80DBC12968", true)]
public void Can_Equate_Move_Event_Infos(int parentId, string entity, string originalPath, Guid parentKey, bool expectedResult)
{
var moveEvent = new MoveEventInfo<string>(entity, originalPath, parentId, parentKey);
var moveEventTwo = new MoveEventInfo<string>("entity", "path", 123, new Guid("063897F1-194A-4C42-B406-CA80DBC12968"));
Assert.AreEqual(expectedResult, moveEvent.Equals(moveEventTwo));
}
}