From 9d9c36b253899ae8ac2b9f30c18385c3bd29a9ea Mon Sep 17 00:00:00 2001 From: Sebastiaan Janssen Date: Wed, 21 Sep 2016 13:04:06 +0200 Subject: [PATCH] U4-9001 Health Check, HTTPS Configuration is missing a message when certificate is valid --- src/Umbraco.Web.UI/umbraco/config/lang/en.xml | 1 + src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml | 1 + src/Umbraco.Web/HealthCheck/Checks/Security/HttpsCheck.cs | 3 +++ 3 files changed, 5 insertions(+) diff --git a/src/Umbraco.Web.UI/umbraco/config/lang/en.xml b/src/Umbraco.Web.UI/umbraco/config/lang/en.xml index 838bbbe8d6..331fc3fe1f 100644 --- a/src/Umbraco.Web.UI/umbraco/config/lang/en.xml +++ b/src/Umbraco.Web.UI/umbraco/config/lang/en.xml @@ -1356,6 +1356,7 @@ To manage your website, simply open the Umbraco back office and start adding con Media - Total XML: %0%, Total: %1%, Total invalid %2% Content - Total XML: %0%, Total published: %1%, Total invalid %2% + Your site certificate was marked as valid. Certificate validation error: '%0%' Error pinging the URL %0% - '%1%' You are currently %0% viewing the site using the HTTPS scheme. diff --git a/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml b/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml index aeeb441281..3a6ac1272e 100644 --- a/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml +++ b/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml @@ -1360,6 +1360,7 @@ To manage your website, simply open the Umbraco back office and start adding con Media - Total XML: %0%, Total: %1%, Total invalid: %2% Content - Total XML: %0%, Total published: %1%, Total invalid: %2% + Your site certificate was marked as valid. Certificate validation error: '%0%' Error pinging the URL %0% - '%1%' You are currently %0% viewing the site using the HTTPS scheme. diff --git a/src/Umbraco.Web/HealthCheck/Checks/Security/HttpsCheck.cs b/src/Umbraco.Web/HealthCheck/Checks/Security/HttpsCheck.cs index 80853c01d8..4e2dc4f8f5 100644 --- a/src/Umbraco.Web/HealthCheck/Checks/Security/HttpsCheck.cs +++ b/src/Umbraco.Web/HealthCheck/Checks/Security/HttpsCheck.cs @@ -84,6 +84,9 @@ namespace Umbraco.Web.HealthCheck.Checks.Security var actions = new List(); + if (success) + message = _textService.Localize("healthcheck/httpsCheckValidCertificate"); + return new HealthCheckStatus(message) {