diff --git a/src/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidator.cs b/src/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidator.cs index f78ce306dd..34fa737fde 100644 --- a/src/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidator.cs +++ b/src/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidator.cs @@ -32,16 +32,14 @@ public class GlobalSettingsValidator private bool ValidateSqlWriteLockTimeOutSetting(TimeSpan configuredTimeOut, out string message) { - // Only apply this setting if it's not excessively high or low + // Only apply this setting if it's not excessively low const int minimumTimeOut = 100; - const int maximumTimeOut = 20000; // between 0.1 and 20 seconds - if (configuredTimeOut.TotalMilliseconds < minimumTimeOut || - configuredTimeOut.TotalMilliseconds > maximumTimeOut) + if (configuredTimeOut.TotalMilliseconds < minimumTimeOut) { message = - $"The `{Constants.Configuration.ConfigGlobal}:{nameof(GlobalSettings.DistributedLockingWriteLockDefaultTimeout)}` setting is not between the minimum of {minimumTimeOut} ms and maximum of {maximumTimeOut} ms"; + $"The `{Constants.Configuration.ConfigGlobal}:{nameof(GlobalSettings.DistributedLockingWriteLockDefaultTimeout)}` should not be configured as less than {minimumTimeOut} ms"; return false; } diff --git a/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidatorTests.cs b/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidatorTests.cs index 3b7d7355b6..4c355d6ca2 100644 --- a/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidatorTests.cs +++ b/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Configuration/Models/Validation/GlobalSettingsValidatorTests.cs @@ -39,16 +39,6 @@ public class GlobalSettingsValidatorTests Assert.False(result.Succeeded); } - [Test] - public void Returns_Fail_For_Configuration_With_Excessive_SqlWriteLockTimeOut() - { - var validator = new GlobalSettingsValidator(); - var options = new GlobalSettings { DistributedLockingWriteLockDefaultTimeout = TimeSpan.Parse("00:00:21") }; - - var result = validator.Validate("settings", options); - Assert.False(result.Succeeded); - } - [Test] public void Returns_Success_For_Configuration_With_Valid_SqlWriteLockTimeOut() {