From 625b8f7e655269a8a1c67b7895e986463133aa4e Mon Sep 17 00:00:00 2001 From: Shannon Date: Wed, 25 Jun 2014 11:26:08 +1000 Subject: [PATCH 1/3] Ensures the 'Index' portion of the path is used for scheduled publishing --- src/Umbraco.Web/Scheduling/ScheduledPublishing.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web/Scheduling/ScheduledPublishing.cs b/src/Umbraco.Web/Scheduling/ScheduledPublishing.cs index 6bc5492973..2d16b08511 100644 --- a/src/Umbraco.Web/Scheduling/ScheduledPublishing.cs +++ b/src/Umbraco.Web/Scheduling/ScheduledPublishing.cs @@ -30,7 +30,7 @@ namespace Umbraco.Web.Scheduling try { var umbracoBaseUrl = ServerEnvironmentHelper.GetCurrentServerUmbracoBaseUrl(); - var url = string.Format("{0}/RestServices/ScheduledPublish/", umbracoBaseUrl); + var url = string.Format("{0}/RestServices/ScheduledPublish/Index", umbracoBaseUrl); using (var wc = new WebClient()) { //pass custom the authorization header From 5aa0621c908637b2ae4dddaeb9d31568b737a391 Mon Sep 17 00:00:00 2001 From: Shannon Date: Wed, 25 Jun 2014 11:36:14 +1000 Subject: [PATCH 2/3] adds some notes --- src/Umbraco.Web/Scheduling/Scheduler.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Umbraco.Web/Scheduling/Scheduler.cs b/src/Umbraco.Web/Scheduling/Scheduler.cs index db3ff1b5ed..a00f7b14f8 100644 --- a/src/Umbraco.Web/Scheduling/Scheduler.cs +++ b/src/Umbraco.Web/Scheduling/Scheduler.cs @@ -13,6 +13,10 @@ namespace Umbraco.Web.Scheduling /// TODO: Much of this code is legacy and needs to be updated, there are a few new/better ways to do scheduling /// in a web project nowadays. /// + /// //TODO: We need a much more robust way of handing scheduled tasks and also need to take into account app shutdowns during + /// a scheduled tasks operation + /// http://haacked.com/archive/2011/10/16/the-dangers-of-implementing-recurring-background-tasks-in-asp-net.aspx/ + /// /// internal sealed class Scheduler : ApplicationEventHandler { From 3aa486a463f658ca98b4a9d3d4242c8601c3a343 Mon Sep 17 00:00:00 2001 From: Shannon Date: Wed, 25 Jun 2014 11:36:58 +1000 Subject: [PATCH 3/3] another log --- src/Umbraco.Web/Scheduling/Scheduler.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Umbraco.Web/Scheduling/Scheduler.cs b/src/Umbraco.Web/Scheduling/Scheduler.cs index a00f7b14f8..a23f942f76 100644 --- a/src/Umbraco.Web/Scheduling/Scheduler.cs +++ b/src/Umbraco.Web/Scheduling/Scheduler.cs @@ -29,6 +29,8 @@ namespace Umbraco.Web.Scheduling if (umbracoApplication.Context == null) return; + LogHelper.Debug(() => "Initializing the scheduler"); + // time to setup the tasks // these are the legacy tasks