From 66cd25d8f56e0e459ed881e9fa3e633fb8b1ed1f Mon Sep 17 00:00:00 2001
From: Shannon <sdeminick@gmail.com>
Date: Wed, 11 Mar 2020 13:10:34 +1100
Subject: [PATCH] Adds notes

---
 .../Composing/DefaultUmbracoAssemblyProvider.cs             | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/Umbraco.Core/Composing/DefaultUmbracoAssemblyProvider.cs b/src/Umbraco.Core/Composing/DefaultUmbracoAssemblyProvider.cs
index c13a42ece7..61d7cff240 100644
--- a/src/Umbraco.Core/Composing/DefaultUmbracoAssemblyProvider.cs
+++ b/src/Umbraco.Core/Composing/DefaultUmbracoAssemblyProvider.cs
@@ -29,6 +29,12 @@ namespace Umbraco.Core.Composing
             _entryPointAssembly = entryPointAssembly ?? throw new ArgumentNullException(nameof(entryPointAssembly));
         }
 
+        // TODO: It would be worth investigating a netcore3 version of this which would use
+        // var allAssemblies = System.Runtime.Loader.AssemblyLoadContext.All.SelectMany(x => x.Assemblies);
+        // that will still only resolve Assemblies that are already loaded but it would also make it possible to
+        // query dynamically generated assemblies once they are added. It would also provide the ability to probe
+        // assembly locations that are not in the same place as the entry point assemblies.
+
         public IEnumerable<Assembly> Assemblies
         {
             get