From 69f805eccae2dbf945de8477ae3979e455312c2a Mon Sep 17 00:00:00 2001
From: Lars-Erik Aabech <lea@markedspartner.no>
Date: Thu, 14 Nov 2013 10:38:56 +0100
Subject: [PATCH] Proof that CreateIndexBuilder.NonClustered() does not affect
 index creation statement on SQL Server.

CreateIndexBuilder_SqlServer_NonClustered_CreatesNonClusteredIndex() fails expecting NONCLUSTERED but getting CLUSTERED.
CreateIndexBuilder_SqlServer_Unique_CreatesUniqueNonClusteredIndex() fails expecting UNIQUE NONCLUSTERED but getting CLUSTERED.
---
 .../SyntaxProvider/SqlSyntaxProviderTests.cs  | 69 +++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/src/Umbraco.Tests/Persistence/SyntaxProvider/SqlSyntaxProviderTests.cs b/src/Umbraco.Tests/Persistence/SyntaxProvider/SqlSyntaxProviderTests.cs
index 3909a17847..cc94620476 100644
--- a/src/Umbraco.Tests/Persistence/SyntaxProvider/SqlSyntaxProviderTests.cs
+++ b/src/Umbraco.Tests/Persistence/SyntaxProvider/SqlSyntaxProviderTests.cs
@@ -1,7 +1,11 @@
 using System;
+using System.Collections.Generic;
 using NUnit.Framework;
 using Umbraco.Core.Models.Rdbms;
+using Umbraco.Core.Persistence.DatabaseAnnotations;
 using Umbraco.Core.Persistence.DatabaseModelDefinitions;
+using Umbraco.Core.Persistence.Migrations.Syntax.Create.Index;
+using Umbraco.Core.Persistence.Migrations.Syntax.Expressions;
 using Umbraco.Core.Persistence.SqlSyntax;
 
 namespace Umbraco.Tests.Persistence.SyntaxProvider
@@ -39,6 +43,71 @@ namespace Umbraco.Tests.Persistence.SyntaxProvider
             }
         }
 
+        [Test]
+        public void Format_SqlServer_NonClusteredIndexDefinition_AddsNonClusteredDirective()
+        {
+            SqlSyntaxContext.SqlSyntaxProvider = SqlServerSyntax.Provider;
+
+            var indexDefinition = CreateIndexDefinition();
+            indexDefinition.IndexType = IndexTypes.NonClustered;
+
+            var actual = SqlSyntaxContext.SqlSyntaxProvider.Format(indexDefinition);
+            Assert.AreEqual("CREATE NONCLUSTERED INDEX [IX_A] ON [TheTable] ([A])", actual);
+        }
+
+        [Test]
+        public void Format_SqlServer_NonClusteredIndexDefinition_UsingIsClusteredFalse_AddsClusteredDirective()
+        {
+            SqlSyntaxContext.SqlSyntaxProvider = SqlServerSyntax.Provider;
+
+            var indexDefinition = CreateIndexDefinition();
+            indexDefinition.IsClustered = false;
+
+            var actual = SqlSyntaxContext.SqlSyntaxProvider.Format(indexDefinition);
+            Assert.AreEqual("CREATE CLUSTERED INDEX [IX_A] ON [TheTable] ([A])", actual);
+        }
+
+        [Test]
+        public void CreateIndexBuilder_SqlServer_NonClustered_CreatesNonClusteredIndex()
+        {
+            SqlSyntaxContext.SqlSyntaxProvider = SqlServerSyntax.Provider;
+            var createExpression = new CreateIndexExpression { Index = { Name = "IX_A" } };
+            var builder = new CreateIndexBuilder(createExpression);
+            builder.OnTable("TheTable").OnColumn("A").Ascending().WithOptions().NonClustered();
+            Assert.AreEqual("CREATE NONCLUSTERED INDEX [IX_A] ON [TheTable] ([A])", createExpression.ToString());
+        }
+
+        [Test]
+        public void CreateIndexBuilder_SqlServer_Unique_CreatesUniqueNonClusteredIndex()
+        {
+            SqlSyntaxContext.SqlSyntaxProvider = SqlServerSyntax.Provider;
+            var createExpression = new CreateIndexExpression { Index = { Name = "IX_A" } };
+            var builder = new CreateIndexBuilder(createExpression);
+            builder.OnTable("TheTable").OnColumn("A").Ascending().WithOptions().Unique();
+            Assert.AreEqual("CREATE UNIQUE NONCLUSTERED INDEX [IX_A] ON [TheTable] ([A])", createExpression.ToString());
+        }
+
+        [Test]
+        public void CreateIndexBuilder_SqlServer_Clustered_CreatesClusteredIndex()
+        {
+            SqlSyntaxContext.SqlSyntaxProvider = SqlServerSyntax.Provider;
+            var createExpression = new CreateIndexExpression { Index = { Name = "IX_A" } };
+            var builder = new CreateIndexBuilder(createExpression);
+            builder.OnTable("TheTable").OnColumn("A").Ascending().WithOptions().Clustered();
+            Assert.AreEqual("CREATE CLUSTERED INDEX [IX_A] ON [TheTable] ([A])", createExpression.ToString());
+        }
+
+        private static IndexDefinition CreateIndexDefinition()
+        {
+            return new IndexDefinition
+            {
+                ColumnName = "A",
+                Name = "IX_A",
+                TableName = "TheTable",
+                SchemaName = "dbo"
+            };
+        }
+
         [TearDown]
         public void TearDown()
         {