From 6bda0b9d4d0bba175a9c2107a0c1582b287bc4e7 Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Mon, 28 Apr 2025 08:52:35 +0200 Subject: [PATCH] remove sort children success notification from repository (#19166) --- .../repository/sort-children-of.repository.ts | 26 ++----------------- .../repository/sort-children-of.repository.ts | 26 ++----------------- 2 files changed, 4 insertions(+), 48 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/sort-children-of/repository/sort-children-of.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/sort-children-of/repository/sort-children-of.repository.ts index 0f79df3e55..c38d45e694 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/sort-children-of/repository/sort-children-of.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/sort-children-of/repository/sort-children-of.repository.ts @@ -1,37 +1,15 @@ import { UmbSortChildrenOfDocumentServerDataSource } from './sort-children-of.server.data.js'; -import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; import { UmbControllerBase } from '@umbraco-cms/backoffice/class-api'; -import type { UmbNotificationContext } from '@umbraco-cms/backoffice/notification'; -import { UMB_NOTIFICATION_CONTEXT } from '@umbraco-cms/backoffice/notification'; import type { UmbSortChildrenOfArgs, UmbSortChildrenOfRepository } from '@umbraco-cms/backoffice/tree'; export class UmbSortChildrenOfDocumentRepository extends UmbControllerBase implements UmbSortChildrenOfRepository { - #dataSource: UmbSortChildrenOfDocumentServerDataSource; - - #notificationContext?: UmbNotificationContext; - - constructor(host: UmbControllerHost) { - super(host); - - this.#dataSource = new UmbSortChildrenOfDocumentServerDataSource(this); - - this.consumeContext(UMB_NOTIFICATION_CONTEXT, (instance) => { - this.#notificationContext = instance; - }); - } + #dataSource = new UmbSortChildrenOfDocumentServerDataSource(this); async sortChildrenOf(args: UmbSortChildrenOfArgs) { if (args.unique === undefined) throw new Error('Unique is missing'); if (!args.sorting) throw new Error('Sorting details are missing'); - const { error } = await this.#dataSource.sortChildrenOf(args); - - if (!error) { - const notification = { data: { message: `Items sorted` } }; - this.#notificationContext?.peek('positive', notification); - } - - return { error }; + return this.#dataSource.sortChildrenOf(args); } } diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/sort-children-of/repository/sort-children-of.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/sort-children-of/repository/sort-children-of.repository.ts index 19025a35ac..95a3349960 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/sort-children-of/repository/sort-children-of.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/sort-children-of/repository/sort-children-of.repository.ts @@ -1,37 +1,15 @@ import { UmbSortChildrenOfMediaServerDataSource } from './sort-children-of.server.data.js'; -import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; import { UmbControllerBase } from '@umbraco-cms/backoffice/class-api'; -import type { UmbNotificationContext } from '@umbraco-cms/backoffice/notification'; -import { UMB_NOTIFICATION_CONTEXT } from '@umbraco-cms/backoffice/notification'; import type { UmbSortChildrenOfArgs, UmbSortChildrenOfRepository } from '@umbraco-cms/backoffice/tree'; export class UmbSortChildrenOfMediaRepository extends UmbControllerBase implements UmbSortChildrenOfRepository { - #dataSource: UmbSortChildrenOfMediaServerDataSource; - - #notificationContext?: UmbNotificationContext; - - constructor(host: UmbControllerHost) { - super(host); - - this.#dataSource = new UmbSortChildrenOfMediaServerDataSource(this); - - this.consumeContext(UMB_NOTIFICATION_CONTEXT, (instance) => { - this.#notificationContext = instance; - }); - } + #dataSource = new UmbSortChildrenOfMediaServerDataSource(this); async sortChildrenOf(args: UmbSortChildrenOfArgs) { if (args.unique === undefined) throw new Error('Unique is missing'); if (!args.sorting) throw new Error('Sorting details are missing'); - const { error } = await this.#dataSource.sortChildrenOf(args); - - if (!error) { - const notification = { data: { message: `Items sorted` } }; - this.#notificationContext?.peek('positive', notification); - } - - return { error }; + return this.#dataSource.sortChildrenOf(args); } }