yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tree Picker: Ensure min/max are numeric

Browse Source 
There is a scenario where the `config.getValueByAlias('maxNumber')`
would return as a `string`. This would cause issues further down when
they are strongly-typed compared, e.g. `max === 1` would be false.

I experienced this issue with the Tree Picker, for setting the
`multiple` property value.
This commit is contained in:
leekelleher
2024-01-04 15:33:55 +00:00
committed by Jacob Overgaard
parent 35bbc472a6
commit 6c76b0292b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/tree-picker/property-editor-ui-tree-picker.element.ts
View File

@@ -45,8 +45,10 @@ export class UmbPropertyEditorUITreePickerElement extends UmbLitElement implemen
this.startNodeId = startNode.id;
}
this.min = config?.getValueByAlias('minNumber') || 0;
this.max = config?.getValueByAlias('maxNumber') || 0;
// TODO: The value from `config.getValueByAlias('maxNumber')` could be a `string`, can't be cast as a `number`. [LK]
// This causes issues when the `max` value is compared against other numbers, e.g. `max === 1` would be false.
this.min = Number(config?.getValueByAlias('minNumber')) || 0;
this.max = Number(config?.getValueByAlias('maxNumber')) || 0;
this.filter = config?.getValueByAlias('filter');
this.showOpenButton = config?.getValueByAlias('showOpenButton');