From 6ca2c27ed3daef241dd36de0834a45d033019b0f Mon Sep 17 00:00:00 2001 From: Kenn Jacobsen Date: Wed, 19 Dec 2018 19:43:18 +0100 Subject: [PATCH] Remove member groups controller TODO's --- .../membergroups/membergroups.controller.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/membergroups/membergroups.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/membergroups/membergroups.controller.js index fd613d8539..6662a86571 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/membergroups/membergroups.controller.js +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/membergroups/membergroups.controller.js @@ -19,12 +19,7 @@ : [model.selectedMemberGroup], function(id) { return parseInt(id) } ); - // TODO: replace with memberGroupResource.getByIds(selectedGroupIds) if it's merged in (see #3845) - or rewrite it for this - memberGroupResource.getGroups().then(function (selectedGroups) { - // TODO: this filter can be removed once we have memberGroupResource.getByIds(selectedGroupIds) - selectedGroups = _.filter(selectedGroups, function(group) { - return selectedGroupIds.indexOf(group.id) >= 0; - }); + memberGroupResource.getByIds(selectedGroupIds).then(function (selectedGroups) { _.each(selectedGroups, function(group) { $scope.model.value[group.name] = true; });