From 6e2576fb0d8e65d2908e0170b968eccc0e8621ae Mon Sep 17 00:00:00 2001 From: Shannon Date: Tue, 8 Sep 2020 11:47:31 +1000 Subject: [PATCH] Ensure the component runs and don't replace UDIs on saving since its not necessary --- src/Umbraco.Web/Compose/BlockEditorComponent.cs | 8 +++++++- src/Umbraco.Web/Compose/BlockEditorComposer.cs | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web/Compose/BlockEditorComponent.cs b/src/Umbraco.Web/Compose/BlockEditorComponent.cs index 0666ba4461..a8b4cfb8ca 100644 --- a/src/Umbraco.Web/Compose/BlockEditorComponent.cs +++ b/src/Umbraco.Web/Compose/BlockEditorComponent.cs @@ -27,7 +27,13 @@ namespace Umbraco.Web.Compose public void Terminate() => _handler?.Dispose(); - private string ReplaceBlockListUdis(string rawJson, bool onlyMissingUdis) => ReplaceBlockListUdis(rawJson, null); + private string ReplaceBlockListUdis(string rawJson, bool onlyMissingUdis) + { + // the block editor doesn't ever have missing UDIs so when this is true there's nothing to process + if (onlyMissingUdis) return rawJson; + + return ReplaceBlockListUdis(rawJson, null); + } // internal for tests internal string ReplaceBlockListUdis(string rawJson, Func createGuid = null) diff --git a/src/Umbraco.Web/Compose/BlockEditorComposer.cs b/src/Umbraco.Web/Compose/BlockEditorComposer.cs index debda081da..e281bcb19f 100644 --- a/src/Umbraco.Web/Compose/BlockEditorComposer.cs +++ b/src/Umbraco.Web/Compose/BlockEditorComposer.cs @@ -7,6 +7,6 @@ namespace Umbraco.Web.Compose /// A composer for Block editors to run a component /// [RuntimeLevel(MinLevel = RuntimeLevel.Run)] - public class BlockEditorComposer : ComponentComposer, ICoreComposer + public class BlockEditorComposer : ComponentComposer, ICoreComposer { } }