From 717efb6b094536782000fa7980e710a34f3666c6 Mon Sep 17 00:00:00 2001 From: Shannon Date: Wed, 20 Feb 2019 20:37:10 +1100 Subject: [PATCH] Removes notes --- .../Services/Implement/PackagingService.cs | 12 ------------ src/Umbraco.Web/Mvc/PluginController.cs | 9 +-------- src/Umbraco.Web/Mvc/UmbracoViewPageOfTModel.cs | 6 ------ 3 files changed, 1 insertion(+), 26 deletions(-) diff --git a/src/Umbraco.Core/Services/Implement/PackagingService.cs b/src/Umbraco.Core/Services/Implement/PackagingService.cs index 5194a26eb5..b4dcc70a96 100644 --- a/src/Umbraco.Core/Services/Implement/PackagingService.cs +++ b/src/Umbraco.Core/Services/Implement/PackagingService.cs @@ -3,26 +3,14 @@ using System.Collections.Generic; using System.IO; using System.Linq; using System.Net.Http; -using System.Text.RegularExpressions; using System.Threading.Tasks; -using System.Web; -using System.Xml.Linq; using Semver; -using Umbraco.Core.Collections; using Umbraco.Core.Events; using Umbraco.Core.Exceptions; using Umbraco.Core.IO; -using Umbraco.Core.Logging; using Umbraco.Core.Models; -using Umbraco.Core.Models.Entities; using Umbraco.Core.Models.Packaging; using Umbraco.Core.Packaging; -using Umbraco.Core.Persistence.Querying; -using Umbraco.Core.Persistence.Repositories; -using Umbraco.Core.PropertyEditors; -using Umbraco.Core.Scoping; -using Umbraco.Core.Strings; -using Content = Umbraco.Core.Models.Content; namespace Umbraco.Core.Services.Implement { diff --git a/src/Umbraco.Web/Mvc/PluginController.cs b/src/Umbraco.Web/Mvc/PluginController.cs index 43c8bb5479..2336bb56d1 100644 --- a/src/Umbraco.Web/Mvc/PluginController.cs +++ b/src/Umbraco.Web/Mvc/PluginController.cs @@ -22,14 +22,7 @@ namespace Umbraco.Web.Mvc // for debugging purposes internal Guid InstanceId { get; } = Guid.NewGuid(); - - // note - // properties marked as [Inject] below will be property-injected (vs constructor-injected) in - // order to keep the constructor as light as possible, so that ppl implementing eg a SurfaceController - // don't need to implement complex constructors + need to refactor them each time we change ours. - // this means that these properties have a setter. - // what can go wrong? - + /// /// Gets the Umbraco context. /// diff --git a/src/Umbraco.Web/Mvc/UmbracoViewPageOfTModel.cs b/src/Umbraco.Web/Mvc/UmbracoViewPageOfTModel.cs index 68359252d4..5ac4037fdb 100644 --- a/src/Umbraco.Web/Mvc/UmbracoViewPageOfTModel.cs +++ b/src/Umbraco.Web/Mvc/UmbracoViewPageOfTModel.cs @@ -26,12 +26,6 @@ namespace Umbraco.Web.Mvc private UmbracoContext _umbracoContext; private UmbracoHelper _helper; - // note - // properties marked as [Inject] below will be property-injected (vs constructor-injected) since - // we have no control over the view constructor (generated by eg the Razor engine). - // this means that these properties have a setter. - // what can go wrong? - /// /// Gets or sets the database context. ///