From 2ec35aa0fa6f3a658cd3cb1754003d81d656172c Mon Sep 17 00:00:00 2001 From: sebastiaan Date: Thu, 6 Sep 2012 07:41:45 -0200 Subject: [PATCH 1/2] Disable Codemirror code completion for IE as it doesn't work properly and mostly just gets in your way --- .../umbraco/developer/Python/editPython.aspx.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs index b338248582..ce94e877fd 100644 --- a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs +++ b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs @@ -87,6 +87,12 @@ namespace umbraco.cms.presentation.developer S = SR.ReadToEnd(); SR.Close(); pythonSource.Text = S; + + //Autosuggest doesn't work properly in IE + if(HttpContext.Current.Request.Browser.Browser == "IE") + { + pythonSource.AutoSuggest = false; + } } private void InitializeComponent() From 422d9a14b2d7c1498d41af93b73467cf62b0df25 Mon Sep 17 00:00:00 2001 From: sebastiaan Date: Thu, 6 Sep 2012 07:49:04 -0200 Subject: [PATCH 2/2] Changed the AutoSuggest to be disabled for IE globally instead of just for scripting files so future autosuggest additions won't show up in IE either --- .../umbraco/developer/Python/editPython.aspx.cs | 6 ------ src/umbraco.controls/CodeArea.cs | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs index ce94e877fd..b338248582 100644 --- a/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs +++ b/src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs @@ -87,12 +87,6 @@ namespace umbraco.cms.presentation.developer S = SR.ReadToEnd(); SR.Close(); pythonSource.Text = S; - - //Autosuggest doesn't work properly in IE - if(HttpContext.Current.Request.Browser.Browser == "IE") - { - pythonSource.AutoSuggest = false; - } } private void InitializeComponent() diff --git a/src/umbraco.controls/CodeArea.cs b/src/umbraco.controls/CodeArea.cs index 9528db9678..cd28223241 100644 --- a/src/umbraco.controls/CodeArea.cs +++ b/src/umbraco.controls/CodeArea.cs @@ -86,7 +86,7 @@ namespace umbraco.uicontrols ClientDependencyLoader.Instance.RegisterDependency(2, "CodeMirror/js/lib/codemirror.css", "UmbracoClient", ClientDependencyType.Css); ClientDependencyLoader.Instance.RegisterDependency(3, "CodeArea/styles.css", "UmbracoClient", ClientDependencyType.Css); - if (AutoSuggest) + if (AutoSuggest && HttpContext.Current.Request.Browser.Browser != "IE") { ClientDependencyLoader.Instance.RegisterDependency(3, "CodeMirror/js/lib/util/simple-hint-customized.js", "UmbracoClient", ClientDependencyType.Javascript);