From 74973d3b21c0027cb8a5e4eef47246f1e7949610 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Thu, 14 Sep 2023 15:19:22 +0200 Subject: [PATCH] correct observer hostConnected, to work thought it was destroyed --- src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.ts b/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.ts index 7dff2bdaf7..18105e8b4e 100644 --- a/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.ts +++ b/src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.ts @@ -46,7 +46,8 @@ export class UmbObserver { } hostConnected() { - if (this.#subscription.closed) { + // Notice: This will not re-subscribe if this controller was destroyed. Only if the subscription was closed. + if (this.#subscription?.closed) { this.#subscription = this.#source.subscribe(this.#callback); } }