From 74a8fcfba6a898bd2dda695816a363b5276ba736 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Mon, 22 Jul 2024 15:14:46 +0200 Subject: [PATCH] feat: convert direct options update to attributes instead --- .../input-markdown-editor/input-markdown.element.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/markdown-editor/components/input-markdown-editor/input-markdown.element.ts b/src/Umbraco.Web.UI.Client/src/packages/markdown-editor/components/input-markdown-editor/input-markdown.element.ts index b9e6386a91..c8135d7053 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/markdown-editor/components/input-markdown-editor/input-markdown.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/markdown-editor/components/input-markdown-editor/input-markdown.element.ts @@ -50,12 +50,6 @@ export class UmbInputMarkdownElement extends UmbFormControlMixin(UmbLitElement, try { this.#editor = this._codeEditor?.editor; - this.#editor?.updateOptions({ - lineNumbers: false, - minimap: false, - folding: false, - }); // Prefer to update options before showing the editor, to avoid seeing the changes in the UI. - // TODO: make all action into extensions this.observe(umbExtensionsRegistry.byType('monacoMarkdownEditorAction'), (manifests) => { manifests.forEach(async (manifest) => { @@ -410,6 +404,9 @@ export class UmbInputMarkdownElement extends UmbFormControlMixin(UmbLitElement,