From a49151f552bf10f80bd73fcd6c13ff74005a563d Mon Sep 17 00:00:00 2001
From: Ronald Barendse <ronald@barend.se>
Date: Mon, 12 Dec 2022 09:11:44 +0100
Subject: [PATCH] Change GetAbsoluteLoggingPath to extension method

---
 .../LoggingSettingsExtensions.cs              | 33 +++++++++++++++++++
 .../Configuration/Models/LoggingSettings.cs   | 25 +++++---------
 2 files changed, 42 insertions(+), 16 deletions(-)
 create mode 100644 src/Umbraco.Core/Configuration/LoggingSettingsExtensions.cs

diff --git a/src/Umbraco.Core/Configuration/LoggingSettingsExtensions.cs b/src/Umbraco.Core/Configuration/LoggingSettingsExtensions.cs
new file mode 100644
index 0000000000..0489a9646d
--- /dev/null
+++ b/src/Umbraco.Core/Configuration/LoggingSettingsExtensions.cs
@@ -0,0 +1,33 @@
+// Copyright (c) Umbraco.
+// See LICENSE for more details.
+
+using Microsoft.Extensions.Hosting;
+using Umbraco.Cms.Core.Configuration.Models;
+using Umbraco.Cms.Core.Extensions;
+
+namespace Umbraco.Extensions;
+
+/// <summary>
+/// Extension methods for <see cref="LoggingSettings" />.
+/// </summary>
+public static class LoggingSettingsExtensions
+{
+    /// <summary>
+    /// Gets the absolute logging path (maps a virtual path to the applications content root).
+    /// </summary>
+    /// <param name="loggingSettings">The logging settings.</param>
+    /// <param name="hostEnvironment">The host environment.</param>
+    /// <returns>
+    /// The absolute logging path.
+    /// </returns>
+    public static string GetAbsoluteLoggingPath(this LoggingSettings loggingSettings, IHostEnvironment hostEnvironment)
+    {
+        var dir = loggingSettings.Directory;
+        if (dir.StartsWith("~/"))
+        {
+            return hostEnvironment.MapPathContentRoot(dir);
+        }
+
+        return dir;
+    }
+}
diff --git a/src/Umbraco.Core/Configuration/Models/LoggingSettings.cs b/src/Umbraco.Core/Configuration/Models/LoggingSettings.cs
index 90498991a4..0489d895b8 100644
--- a/src/Umbraco.Core/Configuration/Models/LoggingSettings.cs
+++ b/src/Umbraco.Core/Configuration/Models/LoggingSettings.cs
@@ -2,13 +2,11 @@
 // See LICENSE for more details.
 
 using System.ComponentModel;
-using Microsoft.Extensions.Hosting;
-using Umbraco.Cms.Core.Extensions;
 
 namespace Umbraco.Cms.Core.Configuration.Models;
 
 /// <summary>
-///     Typed configuration options for logging settings.
+/// Typed configuration options for logging settings.
 /// </summary>
 [UmbracoOptions(Constants.Configuration.ConfigLogging)]
 public class LoggingSettings
@@ -17,25 +15,20 @@ public class LoggingSettings
     internal const string StaticDirectory = Constants.SystemDirectories.LogFiles;
 
     /// <summary>
-    ///     Gets or sets a value for the maximum age of a log file.
+    /// Gets or sets a value for the maximum age of a log file.
     /// </summary>
+    /// <value>
+    /// The maximum log age.
+    /// </value>
     [DefaultValue(StaticMaxLogAge)]
     public TimeSpan MaxLogAge { get; set; } = TimeSpan.Parse(StaticMaxLogAge);
 
     /// <summary>
-    ///     Gets or sets the folder to use for log files
+    /// Gets or sets the folder to use for log files.
     /// </summary>
+    /// <value>
+    /// The directory.
+    /// </value>
     [DefaultValue(StaticDirectory)]
     public string Directory { get; set; } = StaticDirectory;
-
-    public string GetAbsoluteLoggingPath(IHostEnvironment hostEnvironment)
-    {
-        var dir = Directory;
-        if (dir.StartsWith("~/"))
-        {
-            return hostEnvironment.MapPathContentRoot(dir);
-        }
-
-        return dir;
-    }
 }