From 7a3f658ccc46360cdac3512425eb012bffcb310a Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Tue, 7 Jul 2020 14:00:47 +0200 Subject: [PATCH] Dispose StreamReaders Signed-off-by: Bjarke Berg --- .../Extensions/HttpRequestExtensions.cs | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/Umbraco.Web.Common/Extensions/HttpRequestExtensions.cs b/src/Umbraco.Web.Common/Extensions/HttpRequestExtensions.cs index cfb514426a..fb92af11fc 100644 --- a/src/Umbraco.Web.Common/Extensions/HttpRequestExtensions.cs +++ b/src/Umbraco.Web.Common/Extensions/HttpRequestExtensions.cs @@ -61,22 +61,26 @@ namespace Umbraco.Extensions { request.Body.Seek(0, SeekOrigin.Begin); - var reader = new StreamReader(request.Body, encoding ?? Encoding.UTF8); + using (var reader = new StreamReader(request.Body, encoding ?? Encoding.UTF8, leaveOpen: true)) + { + var result = reader.ReadToEnd(); + request.Body.Seek(0, SeekOrigin.Begin); + return result; + } + - var result = reader.ReadToEnd(); - request.Body.Seek(0, SeekOrigin.Begin); - return result; } public static async Task GetRawBodyStringAsync(this HttpRequest request, Encoding encoding = null) { request.Body.Seek(0, SeekOrigin.Begin); - var reader = new StreamReader(request.Body, encoding ?? Encoding.UTF8); - - var result = await reader.ReadToEndAsync(); - request.Body.Seek(0, SeekOrigin.Begin); - return result; + using (var reader = new StreamReader(request.Body, encoding ?? Encoding.UTF8, leaveOpen: true)) + { + var result = await reader.ReadToEndAsync(); + request.Body.Seek(0, SeekOrigin.Begin); + return result; + } } } }