From 7a41d2eab733ab89a2b84640f41ebd9ed6f69690 Mon Sep 17 00:00:00 2001
From: Mads Rasmussen <madsr@hey.com>
Date: Thu, 5 Jan 2023 13:33:06 +0100
Subject: [PATCH] use href in action

---
 .../actions/create/action-data-type-create.element.ts     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/settings/data-types/tree/actions/create/action-data-type-create.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/settings/data-types/tree/actions/create/action-data-type-create.element.ts
index 3d156e161c..af2d692a69 100644
--- a/src/Umbraco.Web.UI.Client/src/backoffice/settings/data-types/tree/actions/create/action-data-type-create.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/backoffice/settings/data-types/tree/actions/create/action-data-type-create.element.ts
@@ -12,16 +12,16 @@ export default class UmbTreeActionDataTypeCreateElement extends UmbTreeItemActio
 		return `section/settings/${this._activeTreeItem?.type}/create/${this._activeTreeItem?.key || 'root'}`;
 	}
 
-	// TODO: change to href. This is a temporary solution to get the link to work. For some reason query params gets removed when using href.
 	private _handleLabelClick() {
 		if (!this._treeContextMenuService) return;
-		const href = this._constructUrl();
-		history.pushState(null, '', href);
 		this._treeContextMenuService.close();
 	}
 
 	render() {
-		return html`<uui-menu-item label=${this.treeAction?.meta.label ?? ''} @click-label="${this._handleLabelClick}">
+		return html`<uui-menu-item
+			label=${this.treeAction?.meta.label ?? ''}
+			@click-label="${this._handleLabelClick}"
+			href="${this._constructUrl()}">
 			<uui-icon slot="icon" name=${this.treeAction?.meta.icon ?? ''}></uui-icon>
 		</uui-menu-item>`;
 	}