yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V10: fix build warnings in test projects (#12509)

Browse Source 
* Run code cleanup

* Dotnet format benchmarks project

* Fix up Test.Common

* Run dotnet format + manual cleanup

* Run code cleanup for unit tests

* Run dotnet format

* Fix up errors

* Manual cleanup of Unit test project

* Update tests/Umbraco.Tests.Benchmarks/HexStringBenchmarks.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Integration/Testing/TestDbMeta.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Benchmarks/TypeFinderBenchmarks.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Integration/Testing/UmbracoIntegrationTest.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Integration/Umbraco.Core/Events/EventAggregatorTests.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Fix according to review

* Fix after merge

* Fix errors

Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Zeegaan <nge@umbraco.dk>
This commit is contained in:
Nikolaj Geisle
2022-06-21 08:09:38 +02:00
committed by GitHub
parent 29961d40a3
commit 7aeb400fce
599 changed files with 87303 additions and 86123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
tests/Umbraco.Tests.UnitTests/Umbraco.Core/ShortStringHelper/StringValidationTests.cs
View File

@@ -1,43 +1,40 @@
// Copyright (c) Umbraco.
// Copyright (c) Umbraco.
// See LICENSE for more details.
using System.ComponentModel.DataAnnotations;
using NUnit.Framework;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.ShortStringHelper
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.ShortStringHelper;
[TestFixture]
public class StringValidationTests
{
[TestFixture]
public class StringValidationTests
[TestCase("someone@somewhere.com", ExpectedResult = true)]
[TestCase("someone@somewhere.co.uk", ExpectedResult = true)]
[TestCase("someone+tag@somewhere.net", ExpectedResult = true)]
[TestCase("futureTLD@somewhere.fooo", ExpectedResult = true)]
[TestCase("abc@xyz.financial", ExpectedResult = true)]
[TestCase("admin+gmail-syntax@c.pizza", ExpectedResult = true)]
[TestCase("admin@c.pizza", ExpectedResult = true)]
[TestCase("fdsa", ExpectedResult = false)]
[TestCase("fdsa@", ExpectedResult = false)]
// IsValid can be either a powerful regex OR a dummy test,
// and by default it depends on System.ComponentModel.DataAnnotations.AppSettings.DisableRegEx
// which ends up using BinaryCompatibility.Current.TargetsAtLeastFramework472 so for some reason
// in 472 we are not using the regex anymore
//
// it can be forced, though with an app settings
// dataAnnotations:dataTypeAttribute:disableRegEx = false
//
// since Umbraco is now 4.7.2+, the setting is required for the following tests to pass
// [TestCase("fdsa@fdsa", ExpectedResult = false)]
// [TestCase("fdsa@fdsa.", ExpectedResult = false)]
public bool Validate_Email_Address(string input)
{
[TestCase("someone@somewhere.com", ExpectedResult = true)]
[TestCase("someone@somewhere.co.uk", ExpectedResult = true)]
[TestCase("someone+tag@somewhere.net", ExpectedResult = true)]
[TestCase("futureTLD@somewhere.fooo", ExpectedResult = true)]
var foo = new EmailAddressAttribute();
[TestCase("abc@xyz.financial", ExpectedResult = true)]
[TestCase("admin+gmail-syntax@c.pizza", ExpectedResult = true)]
[TestCase("admin@c.pizza", ExpectedResult = true)]
[TestCase("fdsa", ExpectedResult = false)]
[TestCase("fdsa@", ExpectedResult = false)]
// IsValid can be either a powerful regex OR a dummy test,
// and by default it depends on System.ComponentModel.DataAnnotations.AppSettings.DisableRegEx
// which ends up using BinaryCompatibility.Current.TargetsAtLeastFramework472 so for some reason
// in 472 we are not using the regex anymore
//
// it can be forced, though with an app settings
// dataAnnotations:dataTypeAttribute:disableRegEx = false
//
// since Umbraco is now 4.7.2+, the setting is required for the following tests to pass
// [TestCase("fdsa@fdsa", ExpectedResult = false)]
// [TestCase("fdsa@fdsa.", ExpectedResult = false)]
public bool Validate_Email_Address(string input)
{
var foo = new EmailAddressAttribute();
return foo.IsValid(input);
}
return foo.IsValid(input);
}
}